[SDK] Feature: added glyph wallet in extra wallets #7973

0xShoobs · 2025-09-03T16:12:24Z

PR-Codex overview

This PR focuses on adding support for the Glyph Wallet and making various updates to existing wallet configurations, including changes to app details, image references, and URL updates for several wallets.

Detailed summary

Added Glyph Wallet to supported wallets.
Updated wallet names and homepages for several wallets.
Changed image IDs for specific wallets.
Modified app platform details (native and universal) for multiple wallets.
Removed deprecated wallet entries and images.
Added auto-generated image files for new wallets.

The following files were skipped due to too many changes: packages/thirdweb/src/wallets/__generated__/wallet/xyz.timelesswallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.useglyph/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.dcentwallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet-ids.ts, packages/thirdweb/src/wallets/__generated__/wallet-infos.ts, packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

New Features
- Added Glyph Wallet as an available option in the wallet connection flow; users can now select it alongside existing wallets.
- Glyph appears with its display name and icon for easier discovery and use.
- This addition does not affect existing wallets, settings, or current wallet selections; it will be available in the upcoming patch release.

changeset-bot · 2025-09-03T16:12:28Z

🦋 Changeset detected

Latest commit: 27cbcb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/nebula	Patch
@thirdweb-dev/wagmi-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphite-app · 2025-09-03T16:12:32Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

vercel · 2025-09-03T16:12:32Z

@shubham-yuga is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-09-03T16:12:33Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (7)

packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet-ids.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet-infos.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.binance.wallet/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.fizen/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.kgen/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.kgen/index.ts is excluded by !**/__generated__/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Adds a new wallet entry "Glyph Wallet" (id: use-glyph) to packages/thirdweb/scripts/wallets/extra-wallets.json with homepage, image_id, rdns, and null placeholders for app, mobile, and desktop fields. Inserted after "Frame Wallet". No other files or logic changed.

Changes

Cohort / File(s)	Summary
Wallet registry data update `packages/thirdweb/scripts/wallets/extra-wallets.json`	Appends a new wallet object for "Glyph Wallet" (id: `use-glyph`) with `homepage`, `image_id`, `rdns`, and all `app`/`mobile`/`desktop` fields set to `null`; positioned after "Frame Wallet".
Release changeset `.changeset/cold-spiders-open.md`	Adds a patch changeset for `thirdweb` noting "Added Glyph wallet to supported wallets".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks (2 passed, 1 warning)

❌ Failed Checks (1 warning)

Check Name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description does not adhere to the repository’s required template; it uses a PR-Codex overview instead of the specified sections and is missing the formatted title, issue tag line, “## Notes for the reviewer”, and “## How to test” headings.	Revise the description to match the provided template by including the “[SDK/Dashboard/Portal] Feature/Fix: Concise title”, the Linear issue tag line, a “## Notes for the reviewer” section, and a “## How to test” section with testing instructions.

✅ Passed Checks (2 passed)

Check Name	Status	Explanation
Title Check	✅ Passed	The title complies with the repository guidelines by following the “[SDK] Feature:” prefix and clearly summarizing the primary change—adding the Glyph Wallet to the extra-wallets list—without extraneous detail.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/thirdweb/scripts/wallets/extra-wallets.json (2)
156-169: Populate app store/extension deep links if available (optional)

If Glyph has a Chrome/Firefox extension or iOS/Android app, add those URLs now so Connect surfaces install flows. Otherwise fine to keep null and update later.

I can add the links if you share them or confirm the correct listing URLs.

151-156: Optional: add order to control placement

Some entries specify "order": 9999999 to push to the end. If you need predictable sorting, add it.

Apply if desired:
   {
     "id": "use-glyph",
     "name": "Glyph Wallet",
     "homepage": "https://useglyph.io/",
     "image_id": "glyph.png",
+    "order": 9999999,

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b8f4966 and bb4d314.

⛔ Files ignored due to path filters (55)

packages/thirdweb/scripts/wallets/extra-wallet-icons/glyph.png is excluded by !**/*.png
packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet-ids.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet-infos.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/ai.purewallet/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/app.edge/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/app.edge/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/app.freighter/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/app.freighter/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/app.imem/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/app.imem/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/app.pluswallet/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/app.xverse/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/cc.maxwallet/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/cc.maxwallet/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.beexo/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.blockchain.login/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.blockchain.login/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.coldwallet/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.coldwallet/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.dcentwallet/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.dcentwallet/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.example.subdomain/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.example.subdomain/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.hootark/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.hootark/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.klipwallet/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.okex.wallet/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.purechain/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.superhero.cordova/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.superhero.cordova/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/com.walletconnect.com/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.prettygood.x/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.prettygood.x/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.r0ar/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.r0ar/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.up/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.useglyph/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.useglyph/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.xenea/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/io.xenea/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/one.mixin.messenger/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/org.ab/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/org.ab/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/org.dailychain.wallet/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/org.dailychain.wallet/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/org.ecoinwallet/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/org.hot-labs.app/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/org.hot-labs.app/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/world.freedom/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/world.freedom/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/xyz.coca/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/xyz.ctrl/index.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/xyz.timelesswallet/image.ts is excluded by !**/__generated__/**
packages/thirdweb/src/wallets/__generated__/wallet/xyz.timelesswallet/index.ts is excluded by !**/__generated__/**

📒 Files selected for processing (1)

packages/thirdweb/scripts/wallets/extra-wallets.json (1 hunks)

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)

📚 Learning: 2025-07-18T19:19:55.613Z

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

Applied to files:

packages/thirdweb/scripts/wallets/extra-wallets.json

📚 Learning: 2025-07-18T19:19:55.613Z

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)

Applied to files:

packages/thirdweb/scripts/wallets/extra-wallets.json

📚 Learning: 2025-07-18T19:19:55.613Z

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture

Applied to files:

packages/thirdweb/scripts/wallets/extra-wallets.json

🔇 Additional comments (3)

packages/thirdweb/scripts/wallets/extra-wallets.json (3)

151-178: Glyph Wallet entry added — looks good

JSON is valid, placement is correct, and fields match existing shape (id/name/homepage/image_id/app/rdns/mobile/desktop).

155-155: glyph.png asset verified
Found at packages/thirdweb/scripts/wallets/extra-wallet-icons/glyph.png; no SVG variant present.

169-169: No changes needed: ‘io.useglyph’ correctly matches the vendor’s reverse domain ‘useglyph.io’.

codecov · 2025-09-03T18:25:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.40%. Comparing base (e78a984) to head (54204e0).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (e78a984) and HEAD (54204e0). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (e78a984) HEAD (54204e0)

packages 2 1

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7973       +/-   ##
===========================================
- Coverage   56.65%   36.40%   -20.25%     
===========================================
  Files         904      897        -7     
  Lines       58677    58180      -497     
  Branches     4165     2328     -1837     
===========================================
- Hits        33241    21181    -12060     
- Misses      25330    36926    +11596     
+ Partials      106       73       -33

Flag	Coverage Δ
packages	`36.40% <ø> (-20.25%)`	⬇️
see 304 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

joaquim-verges · 2025-09-05T07:38:16Z

what's the easiest way to test this?

0xShoobs · 2025-09-08T13:22:28Z

what's the easiest way to test this?

So, this is just half the work. I just added Glyph in the external wallet list.

After this PR is merged to main and a new version is released:

I'll update the thirdweb package in the Glyph SDK
I'll use the "io.useglyph" entry from InjectedSupportedWalletIds (/packages/thirdweb/src/wallets/__generated__/wallet-ids.ts) that will be generated from this PR
Then I'll come back to the Thirdweb SDK code and handle the Glyph Wallet exactly like Abstract is doing it here
Then I'll submit a new PR with that change, so developers would be able to enable Glyph as a wallet.

joaquim-verges · 2025-09-08T22:52:44Z

@shubham-yuga that makes sense. i'll get this in.

for the next PRs, run pnpm changeset from the root of the repo to create a changeset - choose "patch" (press enter 3 times) and enter a change message.

Will do it for you for this one

feat: add glyph wallet in extra wallets

bb4d314

0xShoobs requested review from a team, jnsdls and joaquim-verges as code owners September 3, 2025 16:12

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Sep 3, 2025

coderabbitai bot reviewed Sep 3, 2025

View reviewed changes

Merge branch 'main' into use-glyph/add-external-wallet

985d72f

Merge branch 'main' into use-glyph/add-external-wallet

54204e0

joaquim-verges added 2 commits September 9, 2025 10:55

add changeset

34c2ae4

re-run generate wallets

27cbcb9

joaquim-verges approved these changes Sep 9, 2025

View reviewed changes

joaquim-verges merged commit b149019 into thirdweb-dev:main Sep 9, 2025
5 of 10 checks passed

joaquim-verges mentioned this pull request Sep 9, 2025

Version Packages #8008

Merged

0xShoobs mentioned this pull request Sep 10, 2025

[SDK] Add apechain to supported chains and Add Glyph Wallet Connector #8034

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Feature: added glyph wallet in extra wallets #7973

[SDK] Feature: added glyph wallet in extra wallets #7973

Uh oh!

0xShoobs commented Sep 3, 2025 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 3, 2025

Uh oh!

vercel bot commented Sep 3, 2025

Uh oh!

coderabbitai bot commented Sep 3, 2025 •

edited

Loading

Review skipped

Uh oh!

coderabbitai bot left a comment

Uh oh!

codecov bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

joaquim-verges commented Sep 5, 2025 •

edited

Loading

Uh oh!

0xShoobs commented Sep 8, 2025

Uh oh!

joaquim-verges commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[SDK] Feature: added glyph wallet in extra wallets #7973

[SDK] Feature: added glyph wallet in extra wallets #7973

Uh oh!

Conversation

0xShoobs commented Sep 3, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

graphite-app bot commented Sep 3, 2025

How to use the Graphite Merge Queue

Uh oh!

vercel bot commented Sep 3, 2025

Uh oh!

coderabbitai bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Pre-merge checks (2 passed, 1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joaquim-verges commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xShoobs commented Sep 8, 2025

Uh oh!

joaquim-verges commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

0xShoobs commented Sep 3, 2025 •

edited by pr-codex bot

Loading

changeset-bot bot commented Sep 3, 2025 •

edited

Loading

coderabbitai bot commented Sep 3, 2025 •

edited

Loading

codecov bot commented Sep 3, 2025 •

edited

Loading

joaquim-verges commented Sep 5, 2025 •

edited

Loading