Skip to content

[Dashboard] Update insight query group_by from time to block_timestamp #8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Dashboard] Update insight query group_by from time to block_timestamp #8000

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2512e5f
fix: insights events group_by
gregfromstl Sep 6, 2025
75bd824
[Dashboard] Update insight events API to use chain_id instead of depr…
gregfromstl Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...shboard)/(chain)/[chain_id]/[contractAddress]/analytics/utils/contract-event-breakdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export async function getContractEventBreakdown(params: {
}): Promise<EventBreakdownEntry[]> {
const queryParams = [
`chain=${params.chainId}`,
"group_by=time",
"group_by=block_timestamp",
"group_by=topic_0 as event_signature",
"aggregate=toStartOfDay(toDate(block_timestamp)) as time",
"aggregate=count(*) as count",
Expand Down
2 changes: 1 addition & 1 deletion ...(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/analytics/utils/contract-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export async function getContractEventAnalytics(params: {
}): Promise<AnalyticsEntry[]> {
const queryParams = [
`chain=${params.chainId}`,
"group_by=time",
"group_by=block_timestamp",
"aggregate=toStartOfDay(toDate(block_timestamp)) as time",
Comment on lines +35 to 36
Copy link
Contributor

@graphite-app graphite-app bot Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from group_by=time to group_by=block_timestamp introduces a potential field naming inconsistency. While the grouping parameter now uses block_timestamp, the aggregation still creates a time alias with toStartOfDay(toDate(block_timestamp)) as time.

This mismatch between the grouping field and aggregation alias might cause issues if the backend expects consistent naming between these clauses. Consider either:

  1. Updating the aggregation to use a matching alias:

    "aggregate=toStartOfDay(toDate(block_timestamp)) as block_timestamp"

  2. Or documenting why this apparent inconsistency is intentional and safe in this context

This would ensure the query parameters maintain logical consistency and reduce the risk of unexpected behavior.

Suggested change
"group_by=block_timestamp",
"aggregate=toStartOfDay(toDate(block_timestamp)) as time",
"group_by=block_timestamp",
"aggregate=toStartOfDay(toDate(block_timestamp)) as block_timestamp",

Spotted by Diamond

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

"aggregate=count(block_timestamp) as count",
params.startDate
Expand Down
Loading