Skip to content

[MNY-163] Portal: Fix broken links in payments sidebar #8021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

[MNY-163] Portal: Fix broken links in payments sidebar #8021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions apps/portal/src/app/bridge/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExternalLinkIcon, ZapIcon } from "lucide-react";
import { ZapIcon } from "lucide-react";
import type { SideBar } from "@/components/Layouts/DocLayout";
import { EngineIcon, ReactIcon, TypeScriptIcon, UnityIcon } from "@/icons";
import { UnrealEngineIcon } from "../../icons/sdks/UnrealEngineIcon";
Expand All @@ -12,11 +12,6 @@ export const sidebar: SideBar = {
name: "Get Started",
icon: <ZapIcon />,
},
{
href: "https://playground.thirdweb.com/",
icon: <ExternalLinkIcon />,
name: "Playground",
},
{ separator: true },
{
isCollapsible: false,
Expand Down
10 changes: 5 additions & 5 deletions apps/portal/src/app/payments/sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const sidebar: SideBar = {
icon: <ZapIcon />,
},
{
href: "https://playground.thirdweb.com/",
href: "https://playground.thirdweb.com/payments",
icon: <ExternalLinkIcon />,
name: "Playground",
},
Comment on lines +16 to 19
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Playground URL change: confirm target exists and is treated as external

Looks right; please verify the /payments subpath is live and that our link renderer opens it in a new tab with rel="noopener".

Run:

🏁 Script executed:

#!/bin/bash
set -euo pipefail
for url in https://playground.thirdweb.com/ https://playground.thirdweb.com/payments; do
  code=$(curl -sI "$url" | awk '/^HTTP/{print $2}' | head -n1)
  echo "$url -> HTTP $code"
done

Length of output: 97

🏁 Script executed:

#!/bin/bash
set -euo pipefail
find . -type f -name "sidebar.tsx"

Length of output: 1096

🏁 Script executed:

#!/bin/bash
set -euo pipefail
sed -n '1,200p' apps/portal/src/app/payments/sidebar.tsx

Length of output: 2788

🏁 Script executed:

#!/bin/bash
set -euo pipefail
find apps/portal/src -type f | grep -i DocLayout

Length of output: 48

🏁 Script executed:

#!/bin/bash
set -euo pipefail
sed -n '1,500p' apps/portal/src/components/Layouts/DocLayout.tsx

Length of output: 2249

🏁 Script executed:

#!/bin/bash
set -euo pipefail
sed -n '1,200p' apps/portal/src/components/others/Sidebar.tsx

Length of output: 5522

Add rel="noopener noreferrer" to external links in SidebarItem
Verified https://playground.thirdweb.com/payments returns HTTP 200; the Next.js Link in SidebarItem (apps/portal/src/components/others/Sidebar.tsx) sets target="_blank" for external URLs but omits rel—update it to rel="noopener noreferrer".

🤖 Prompt for AI Agents 
In apps/portal/src/app/payments/sidebar.tsx around lines 16-19, the Playground
external link uses target="_blank" via SidebarItem but omits rel; modify the
SidebarItem rendering logic in apps/portal/src/components/others/Sidebar.tsx so
that whenever an anchor is rendered with target="_blank" for external URLs it
also includes rel="noopener noreferrer" (ensure the prop is added to the
Link/anchor element generation path for external links).

Expand All @@ -38,19 +38,19 @@ export const sidebar: SideBar = {
name: "Send a Payment",
},
{
href: `bridge/sell`,
href: `/bridge/sell`,
name: "Sell Tokens",
},
{
href: `bridge/swap`,
href: `/bridge/swap`,
name: "Swap Tokens",
},
{
href: `bridge/tokens`,
href: `/bridge/tokens`,
name: "Get Token Prices",
},
{
href: `bridge/routes`,
href: `/bridge/routes`,
name: "Get Routes",
},
{
Expand Down
Loading