-
Notifications
You must be signed in to change notification settings - Fork 619
Version Packages #8037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8037
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughBumps versions for nebula, thirdweb, and wagmi-adapter packages, updates corresponding changelogs, and removes a pending changeset entry related to thirdweb authorizationList passthrough. No source code or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Pre-merge checks (1 passed, 1 warning, 1 inconclusive)❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing Touches🧪 Generate unit tests
Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/nebula/package.json (1)
46-56: Introduce bundle size budgets withsize-limit
Neitherpackages/nebula/package.jsonnor the rootpackage.jsoninclude asize-limitconfig. Add asize-limitsection and a"size"script in thescriptsblock (or confirm coverage via a central config) in a follow-up PR to track bundle sizes.packages/wagmi-adapter/package.json (1)
45-54: Add size-limit config for wagmi-adapter
No “size-limit” setup found for wagmi-adapter (neither in packages/wagmi-adapter nor at repo root). Add a .size-limit.json in packages/wagmi-adapter (or extend the root config) and asizescript in its package.json—e.g. model budgets after packages/thirdweb/.size-limit.json—to track bundle size and prevent regressions.packages/thirdweb/CHANGELOG.md (1)
7-7: Nit: capitalize and format the property name for consistency.Most prior entries start with a capitalized verb and wrap identifiers in code ticks.
- - [#8036](https://github.com/thirdweb-dev/js/pull/8036) [`ef15ba7`](https://github.com/thirdweb-dev/js/commit/ef15ba7c434f8c9bde3b6d45d43d90e74f20616b) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - pass through authorizationList for injected providers + - [#8036](https://github.com/thirdweb-dev/js/pull/8036) [`ef15ba7`](https://github.com/thirdweb-dev/js/commit/ef15ba7c434f8c9bde3b6d45d43d90e74f20616b) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Pass through `authorizationList` for injected providerspackages/wagmi-adapter/CHANGELOG.md (1)
3-4: Add a brief note under 0.2.141 for clarity.Empty headers can be confusing; add a “version bump only” line.
Apply this diff:
## 0.2.141 + +### Patch Changes +- No user-facing changes; version bump only via Changesets release.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/twelve-ducks-beg.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/twelve-ducks-beg.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.jsonpackages/wagmi-adapter/package.jsonpackages/nebula/package.json
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
packages/thirdweb/package.json (2)
420-420: Version bump looks goodPatch release to 5.105.44 aligns with the changelog entry; no other manifest changes.
335-336: Size-limit budgets found inpackages/thirdweb/.size-limit.json. No further action needed.packages/nebula/package.json (1)
60-60: Nebula version bump acknowledgedIncrement to 0.2.44 matches the dependency update to [email protected].
packages/wagmi-adapter/package.json (1)
58-58: Wagmi adapter version bump OK0.2.141 published; peer ranges still compatible with thirdweb 5.105.44.
packages/thirdweb/CHANGELOG.md (1)
3-8: LGTM: version bump entry looks correct.Entry 5.105.44 and summary align with the release PR scope.
packages/nebula/CHANGELOG.md (1)
3-9: Nebula changelog entry is correct and consistent.Dependency bump note and commit link look good.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8037 +/- ##
==========================================
+ Coverage 56.61% 56.63% +0.01%
==========================================
Files 904 904
Lines 58684 58684
Branches 4159 4162 +3
==========================================
+ Hits 33223 33233 +10
+ Misses 25357 25345 -12
- Partials 104 106 +2
🚀 New features to boost your workflow:
|
Ari4ka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
ef15ba7]:[email protected]
Patch Changes
ef15ba7Thanks @joaquim-verges! - pass through authorizationList for injected providers@thirdweb-dev/[email protected]
PR-Codex overview
This PR primarily focuses on updating version numbers and changelogs for various packages, including
thirdweb,nebula, andwagmi-adapter. It also includes a new dependency update forthirdweb.Detailed summary
.changeset/twelve-ducks-beg.mdversioninpackages/thirdweb/package.jsonfrom5.105.43to5.105.44versioninpackages/nebula/package.jsonfrom0.2.43to0.2.44versioninpackages/wagmi-adapter/package.jsonfrom0.2.140to0.2.141nebulaversion0.2.44with dependency update for[email protected]thirdwebversion5.105.44detailing a fix related toauthorizationListfor injected providersSummary by CodeRabbit