Skip to content

Conversation

@viktorking7
Copy link

@viktorking7 viktorking7 commented Sep 21, 2025

This PR addresses several spelling errors found across the codebase:

### Files Changed
- **`notification-list.tsx`**: Fixed "defualt" → "default" in comment
- **`useLocalStorage.ts`**: Fixed "alernatively" → "alternatively" in comment  
- **`utils.tsx`**: Fixed "mesages" → "messages" in function parameter

PR-Codex overview

This PR focuses on improving code clarity and fixing minor typos in the notification-list.tsx, utils.tsx, and useLocalStorage.ts files.

Detailed summary

  • Corrected the comment in notification-list.tsx from "defualt" to "default".
  • Fixed the spelling of mesages to messages in utils.tsx.
  • Corrected the spelling of "alernatively" to "alternatively" in useLocalStorage.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Documentation

    • Corrected minor typos in comments within notifications and local storage code. No changes to app behavior.
  • Chores

    • Standardized a parameter name in a Storybook logging helper for consistency. No user-facing impact.

No user-visible features or fixes in this release; these updates improve code clarity and developer experience without altering functionality.

Signed-off-by: viktorking7 <[email protected]>
Signed-off-by: viktorking7 <[email protected]>
Signed-off-by: viktorking7 <[email protected]>
@viktorking7 viktorking7 requested review from a team as code owners September 21, 2025 09:58
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2025

⚠️ No Changeset found

Latest commit: 876b7d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 21, 2025

@viktorking7 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 21, 2025
@github-actions
Copy link
Contributor

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Sep 29, 2025
@viktorking7
Copy link
Author

@jnsdls

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 29, 2025

Walkthrough

Minor text and naming corrections across dashboard code: two comment typo fixes and a rest parameter rename in a Storybook utility function. No logic, control flow, or runtime behavior changes.

Changes

Cohort / File(s) Summary
Comment typo fixes
apps/dashboard/src/@/components/notifications/notification-list.tsx, apps/dashboard/src/@/hooks/useLocalStorage.ts
Corrected misspellings in comments; no code or behavior changes.
Storybook utils parameter rename
apps/dashboard/src/@/storybook/utils.tsx
Renamed rest parameter from mesages to messages in storybookLog and updated usage; exported function signature’s parameter name changed without affecting types or behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description does not follow the repository’s required template since it omits the commented header with title format guidance, fails to include a branch or issue tag, and lacks the “Notes for the reviewer” and “How to test” sections specified in the description template. Please add the commented template block at the top of the description, fill in the title in the “[SDK/Dashboard/Portal] Feature/Fix: …” format and include any issue tag, then provide “Notes for the reviewer” detailing pertinent context and a “How to test” section describing steps or commands for verification.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the core change—correcting typos in comments and function parameters—and uses the conventional “fix:” prefix to indicate the nature of the update, clearly reflecting the main modifications without superfluous detail.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e2931df and 876b7d4.

📒 Files selected for processing (3)
  • apps/dashboard/src/@/components/notifications/notification-list.tsx (1 hunks)
  • apps/dashboard/src/@/hooks/useLocalStorage.ts (1 hunks)
  • apps/dashboard/src/@/storybook/utils.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from @/types where applicable
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size

Files:

  • apps/dashboard/src/@/hooks/useLocalStorage.ts
  • apps/dashboard/src/@/storybook/utils.tsx
  • apps/dashboard/src/@/components/notifications/notification-list.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

  • apps/dashboard/src/@/hooks/useLocalStorage.ts
  • apps/dashboard/src/@/storybook/utils.tsx
  • apps/dashboard/src/@/components/notifications/notification-list.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from @/components/ui/* (Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
Use NavLink for internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Use cn() from @/lib/utils for conditional class logic
Use design system tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components (Node edge): Start files with import "server-only";
Client Components (browser): Begin files with 'use client';
Always call getAuthToken() to retrieve JWT from cookies on server side
Use Authorization: Bearer header – never embed tokens in URLs
Return typed results (e.g., Project[], User[]) – avoid any
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stable queryKeys for React Query cache hits
Configure staleTime/cacheTime in React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never import posthog-js in server components

Files:

  • apps/dashboard/src/@/hooks/useLocalStorage.ts
  • apps/dashboard/src/@/storybook/utils.tsx
  • apps/dashboard/src/@/components/notifications/notification-list.tsx
apps/{dashboard,playground}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

apps/{dashboard,playground}/**/*.{ts,tsx}: Import UI primitives from @/components/ui/_ (e.g., Button, Input, Tabs, Card)
Use NavLink for internal navigation to get active state handling
Use Tailwind CSS for styling; no inline styles
Merge class names with cn() from @/lib/utils for conditional classes
Stick to design tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components must start with import "server-only"; use next/headers, server‑only env, heavy data fetching, and redirect() where appropriate
Client Components must start with 'use client'; handle interactivity with hooks and browser APIs
Server-side data fetching: call getAuthToken() from cookies, send Authorization: Bearer <token> header, and return typed results (avoid any)
Client-side data fetching: wrap calls in React Query with descriptive, stable queryKeys and set sensible staleTime/cacheTime (≥ 60s default); keep tokens secret via internal routes or server actions
Do not import posthog-js in server components (client-side only)

Files:

  • apps/dashboard/src/@/hooks/useLocalStorage.ts
  • apps/dashboard/src/@/storybook/utils.tsx
  • apps/dashboard/src/@/components/notifications/notification-list.tsx
apps/{dashboard,playground}/**/*.tsx

📄 CodeRabbit inference engine (AGENTS.md)

Expose a className prop on the root element of every component

Files:

  • apps/dashboard/src/@/storybook/utils.tsx
  • apps/dashboard/src/@/components/notifications/notification-list.tsx
🔇 Additional comments (3)
apps/dashboard/src/@/hooks/useLocalStorage.ts (1)

13-13: Comment typo fix looks good

Thanks for tightening up the FIXME wording here; clearer guidance helps future refactors.

apps/dashboard/src/@/components/notifications/notification-list.tsx (1)

17-18: Clarified fallback comment reads well

The updated wording nails the archive fallback explanation—thanks for the polish.

apps/dashboard/src/@/storybook/utils.tsx (1)

37-42: Parameter rename improves readability

Renaming the rest arg to messages keeps the debug helper self-explanatory. Nice touch.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants