Skip to content

[SDK] Fix transaction parameter ordering in injected wallet #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

[SDK] Fix transaction parameter ordering in injected wallet #8109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/thirdweb/src/wallets/injected/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,16 +201,17 @@
};
const params = [
{
...tx,
authorizationList: tx.authorizationList
? ox__Authorization.toRpcList(tx.authorizationList)
: undefined,
...gasFees,
from: this.address,
gas: tx.gas ? numberToHex(tx.gas) : undefined,
nonce: tx.nonce ? numberToHex(tx.nonce) : undefined,
to: tx.to ? getAddress(tx.to) : undefined,
data: tx.data,

Check warning on line 209 in packages/thirdweb/src/wallets/injected/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/wallets/injected/index.ts#L209 

Added line #L209 was not covered by tests
value: tx.value ? numberToHex(tx.value) : undefined,
authorizationList: tx.authorizationList
? ox__Authorization.toRpcList(tx.authorizationList)
: undefined,
accessList: tx.accessList,

Check warning on line 214 in packages/thirdweb/src/wallets/injected/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/wallets/injected/index.ts#L211-L214 

Added lines #L211 - L214 were not covered by tests
...tx.eip712,
},
];
Expand Down
Loading