Playground: Use Geist fonts #8133
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughReplaces Inter and Fira Code font setup with Geist Sans and Geist Mono across the web app, adds the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
github-actions
bot
added
the
Playground
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8133 +/- ##
=======================================
Coverage 56.27% 56.27%
=======================================
Files 906 906
Lines 59193 59193
Branches 4173 4173
=======================================
Hits 33311 33311
Misses 25777 25777
Partials 105 105
🚀 New features to boost your workflow:
|
size-limit report 📦
|
graphite-app
bot
changed the base branch from
09-26-playground_fix_connectembed_width
to
graphite-base/8133
graphite-app
bot
force-pushed
the
09-26-playground_use_geist_fonts
branch
from
10fd90f to
5ea8675
Compare
graphite-app
bot
force-pushed
the
graphite-base/8133
branch
from
e141be7 to
51390f3
Compare
graphite-app
bot
force-pushed
the
09-26-playground_use_geist_fonts
branch
from
5ea8675 to
053502f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/playground-web/src/app/layout.tsx (1)
27-31: Mark as server-only and add explicit return type
- Add import "server-only" to enforce server component boundaries.
- Provide an explicit return type for RootLayout per TS guidelines.
As per coding guidelines
You can apply these outside the shown hunk:
// at the very top of the file import "server-only";// function signature export default async function RootLayout({ children, }: { children: React.ReactNode; }): Promise<JSX.Element> {apps/playground-web/tailwind.config.ts (1)
11-13: Preserve base font families and add generic fallbacksCurrent block overwrites any upstream fontFamily extensions and lacks generic fallbacks. Merge with base config and add "sans-serif"/"monospace" to be resilient if fonts fail to load.
Apply this diff:
- fontFamily: { - sans: ["var(--font-geist-sans)"], - mono: ["var(--font-geist-mono)"], - }, + fontFamily: { + ...(tailwindConfig.theme?.extend?.fontFamily || {}), + sans: [ + "var(--font-geist-sans)", + ...(tailwindConfig.theme?.extend?.fontFamily?.sans ?? []), + "system-ui", + "sans-serif", + ], + mono: [ + "var(--font-geist-mono)", + ...(tailwindConfig.theme?.extend?.fontFamily?.mono ?? []), + "ui-monospace", + "SFMono-Regular", + "Menlo", + "monospace", + ], + },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
apps/playground-web/package.json(1 hunks)apps/playground-web/src/app/layout.tsx(2 hunks)apps/playground-web/tailwind.config.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
apps/playground-web/tailwind.config.tsapps/playground-web/src/app/layout.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
apps/playground-web/tailwind.config.tsapps/playground-web/src/app/layout.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/*(Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
UseNavLinkfor internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Usecn()from@/lib/utilsfor conditional class logic
Use design system tokens (e.g.,bg-card,border-border,text-muted-foreground)
Server Components (Node edge): Start files withimport "server-only";
Client Components (browser): Begin files with'use client';
Always callgetAuthToken()to retrieve JWT from cookies on server side
UseAuthorization: Bearerheader – never embed tokens in URLs
Return typed results (e.g.,Project[],User[]) – avoidany
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stablequeryKeysfor React Query cache hits
ConfigurestaleTime/cacheTimein React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never importposthog-jsin server components
Files:
apps/playground-web/tailwind.config.tsapps/playground-web/src/app/layout.tsx
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
apps/playground-web/package.json
🧠 Learnings (4)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to apps/{dashboard,playground}/**/*.{ts,tsx} : Use Tailwind CSS for styling; no inline styles
Applied to files:
apps/playground-web/tailwind.config.tsapps/playground-web/src/app/layout.tsx
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use Tailwind CSS only – no inline styles or CSS modules
Applied to files:
apps/playground-web/tailwind.config.tsapps/playground-web/src/app/layout.tsx
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use design system tokens (e.g., `bg-card`, `border-border`, `text-muted-foreground`)
Applied to files:
apps/playground-web/src/app/layout.tsx
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to apps/{dashboard,playground}/**/*.{ts,tsx} : Stick to design tokens (e.g., bg-card, border-border, text-muted-foreground)
Applied to files:
apps/playground-web/src/app/layout.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
apps/playground-web/package.json (1)
29-29: Geist dependency addition looks goodVersion ^1.5.1 is current and stable; aligns with the layout/tailwind changes.
apps/playground-web/src/app/layout.tsx (1)
7-8: Geist font imports are correctUsing geist/font/mono and geist/font/sans with .variable matches Tailwind’s CSS variable mapping.
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR primarily focuses on integrating the `geist` font into the `playground-web` application, updating the `tailwind` configuration, and replacing existing font imports with `GeistSans` and `GeistMono`.
### Detailed summary
- Added `geist` dependency in `package.json`.
- Updated `tailwind.config.ts` to extend the theme with `geist` font families.
- Replaced `Fira_Code` and `Inter` font imports in `layout.tsx` with `GeistMono` and `GeistSans`.
- Updated the body class to use `GeistSans` and `GeistMono` variables.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- Style
- Updated global typography to Geist Sans and Geist Mono for a cleaner, consistent look.
- Replaced previous Inter and Fira Code fonts with new Geist font variables in the app layout.
- Configured Tailwind to use Geist-based sans and mono font families across the app.
- Chores
- Added Geist font package as a new dependency.
- Notes
- No functional changes; visual update limited to typography.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
09-26-playground_use_geist_fonts
branch
from
053502f to
108a79a
Compare
PR-Codex overview
This PR focuses on enhancing the
playground-webapplication by adding thegeistfont library and updating thetailwind.config.tsto extend the theme with new font families. It also replaces the existing font imports inlayout.tsxwithGeistSansandGeistMono.Detailed summary
geistlibrary topackage.json.tailwind.config.tsto extend the theme with new font families:sans:var(--font-geist-sans)mono:var(--font-geist-mono)InterandFira_Codeimports inlayout.tsxwithGeistSansandGeistMono.<body>tag to useGeistSansandGeistMonovariables.Summary by CodeRabbit
Style
Chores
Notes