Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Sep 26, 2025


PR-Codex overview

This PR focuses on minor adjustments to the layout and styling of components in the dashboard, specifically in grid-pattern-embed-container.tsx and BuyAndSwapEmbed.tsx.

Detailed summary

  • In grid-pattern-embed-container.tsx, removed the fixed width class from the <div>, allowing it to be responsive.
  • In BuyAndSwapEmbed.tsx, removed the width class from the <SwapWidget> to maintain a consistent border styling without enforcing a full width.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Style
    • Buy and Swap widgets no longer force full width and now adapt to their container while keeping rounded, borderless visuals.
    • Embed container relaxes small-screen width limits so content can use available space more naturally.
    • Improves responsiveness, spacing, and alignment across devices; visual-only changes with no behavior or control updates.

@vercel
Copy link

vercel bot commented Sep 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Sep 26, 2025 5:05pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Sep 26, 2025 5:05pm
nebula Skipped Skipped Sep 26, 2025 5:05pm
thirdweb_playground Skipped Skipped Sep 26, 2025 5:05pm
wallet-ui Skipped Skipped Sep 26, 2025 5:05pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2025 16:43 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula September 26, 2025 16:43 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2025

⚠️ No Changeset found

Latest commit: b888413

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 26, 2025 16:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 26, 2025 16:43 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 26, 2025

Walkthrough

Removed forced width utilities from Buy/Swap widgets and the grid-pattern embed container’s inner div, altering layout width behavior without changing logic, structure, or exports.

Changes

Cohort / File(s) Summary
Widget width utilities removed
apps/dashboard/src/@/components/blocks/BuyAndSwapEmbed.tsx
Dropped !w-full from BuyWidget and SwapWidget className values; retained rounded and border-none styles; no logic or control-flow changes.
Embed container width constraint removed
apps/dashboard/src/@/components/blocks/grid-pattern-embed-container.tsx
Removed sm:w-[420px] from inner container div; now only z-10, so inner wrapper is no longer constrained on small screens; structure unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description includes the template comments but does not fill in any of the required sections such as the formatted title, issue tag, notes for the reviewer, or instructions on how to test, and instead only contains an AI-generated Codex summary. Please populate the description template by adding the formatted title line, include any issue or ticket tag, provide clear notes for the reviewer, and specify steps for how to test the changes in the dashboard.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title concisely and accurately summarizes the primary change of fixing the BuyAndSwapWidget width in the dashboard, directly reflecting the modifications in the changeset without extra detail or ambiguity.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 09-26-dashboard_fix_buyandswapwidget_width

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 35e0198 and b888413.

📒 Files selected for processing (2)
  • apps/dashboard/src/@/components/blocks/BuyAndSwapEmbed.tsx (2 hunks)
  • apps/dashboard/src/@/components/blocks/grid-pattern-embed-container.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/dashboard/src/@/components/blocks/BuyAndSwapEmbed.tsx
  • apps/dashboard/src/@/components/blocks/grid-pattern-embed-container.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@MananTank MananTank marked this pull request as ready for review September 26, 2025 16:44
@MananTank MananTank requested review from a team as code owners September 26, 2025 16:44
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 26, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.27%. Comparing base (108a79a) to head (b888413).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8134   +/-   ##
=======================================
  Coverage   56.27%   56.27%           
=======================================
  Files         906      906           
  Lines       59193    59193           
  Branches     4173     4173           
=======================================
  Hits        33311    33311           
  Misses      25777    25777           
  Partials      105      105           
Flag Coverage Δ
packages 56.27% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Sep 26, 2025 — with Graphite App
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.09 KB (0%) 1.3 s (0%) 183 ms (+272.58% 🔺) 1.5 s
thirdweb (cjs) 361.63 KB (0%) 7.3 s (0%) 588 ms (+17.16% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 76 ms (+3008.82% 🔺) 190 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 26 ms (+980.34% 🔺) 37 ms
thirdweb/react (minimal + tree-shaking) 19.14 KB (0%) 383 ms (0%) 71 ms (+2472.23% 🔺) 454 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 26, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on making minor adjustments to the layout and styling of components in the dashboard, specifically in `grid-pattern-embed-container.tsx` and `BuyAndSwapEmbed.tsx`.

### Detailed summary
- In `grid-pattern-embed-container.tsx`, the width class `sm:w-[420px]` was removed from the `div`, allowing it to take its natural width.
- In `BuyAndSwapEmbed.tsx`, the width class `!w-full` was removed from two instances of `SwapWidget`, maintaining the rounded border style but removing the full width constraint.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* Style
  * Buy and Swap widgets no longer force full-width, adapting to their container while preserving rounded, borderless styling.
  * Embed container relaxes small-screen width limits, allowing content to use available space more naturally.
  * Improves responsiveness, spacing, and alignment across devices, reducing unnecessary whitespace and preventing overstretched layouts.
  * Visual update only; no changes to widget behavior or controls.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 09-26-dashboard_fix_buyandswapwidget_width branch from 35e0198 to b888413 Compare September 26, 2025 16:56
@vercel vercel bot temporarily deployed to Preview – nebula September 26, 2025 16:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 26, 2025 16:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 26, 2025 16:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2025 16:56 Inactive
@graphite-app graphite-app bot merged commit b888413 into main Sep 26, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 09-26-dashboard_fix_buyandswapwidget_width branch September 26, 2025 17:06
@graphite-app graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label Sep 26, 2025
@vercel vercel bot temporarily deployed to Production – nebula September 26, 2025 17:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants