Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Sep 29, 2025


PR-Codex overview

This PR focuses on updating the styles for the .changelog-page in the styles.css file by removing the underline styles from links.

Detailed summary

  • Removed the following styles from .changelog-page a:
    • text-decoration: underline;
    • text-decoration-color: hsl(var(--muted-foreground));
    • text-decoration-style: dotted;
    • color: hsl(var(--foreground));
    • text-underline-offset: 5px;
    • transition: color 200ms ease;

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Style
    • Updated link appearance on the changelog page to align with global styles: removed custom underlines, dotted/colored underline styling, underline offset, and color transition for regular links. Headings remain without underlines and hover behavior is unchanged. Result is a cleaner, more consistent visual experience with no functional changes.

@vercel vercel bot temporarily deployed to Preview – wallet-ui September 29, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 29, 2025 20:14 Inactive
@vercel
Copy link

vercel bot commented Sep 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Sep 30, 2025 0:27am
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
nebula Skipped Skipped Sep 30, 2025 0:27am
thirdweb_playground Skipped Skipped Sep 30, 2025 0:27am
thirdweb-www Skipped Skipped Sep 30, 2025 0:27am
wallet-ui Skipped Skipped Sep 30, 2025 0:27am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 29, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula September 29, 2025 20:14 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2025

⚠️ No Changeset found

Latest commit: 0c7149e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 29, 2025

Walkthrough

Removed a CSS block that styled .changelog-page a (underline, underline-color, dotted style, text color, text-underline-offset, transition). The rule .changelog-page h2 a { text-decoration: none; } and existing .changelog-page a:hover rules remain unchanged.

Changes

Cohort / File(s) Summary
Changelog page CSS
apps/portal/src/app/changelog/[slug]/styles.css
Removed the .changelog-page a { ... } block that customized link underline, underline color, dotted style, color, text-underline-offset, and transition; retained .changelog-page h2 a { text-decoration: none; } and hover rules.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description contains only the commented-out template and an AI-generated summary without filling in the required sections such as a formatted title header, issue tag, notes for the reviewer, and testing instructions, leaving the template placeholders unpopulated. Please populate the commented template by specifying the PR’s formatted title or issue tag, adding relevant notes for the reviewer, and detailing how to test the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title succinctly describes the primary change by identifying the Portal component and clearly stating that link underlines are being removed from the changelog page, matching the actual modifications in styles.css.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 09-30-portal_remove_underlines_from_links_in_changelog_page

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2326b75 and 0c7149e.

📒 Files selected for processing (1)
  • apps/portal/src/app/changelog/[slug]/styles.css (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/portal/src/app/changelog/[slug]/styles.css
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Sep 29, 2025
@MananTank MananTank marked this pull request as ready for review September 29, 2025 20:15
@MananTank MananTank requested review from a team as code owners September 29, 2025 20:15
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.28%. Comparing base (ce9220e) to head (0c7149e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8148   +/-   ##
=======================================
  Coverage   56.28%   56.28%           
=======================================
  Files         906      906           
  Lines       59208    59208           
  Branches     4176     4176           
=======================================
  Hits        33324    33324           
  Misses      25779    25779           
  Partials      105      105           
Flag Coverage Δ
packages 56.28% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.69 KB (0%) 1.3 s (0%) 364 ms (+24.05% 🔺) 1.7 s
thirdweb (cjs) 361.52 KB (0%) 7.3 s (0%) 2.3 s (-3.54% 🔽) 9.5 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 103 ms (+597.96% 🔺) 218 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 32 ms (+335.27% 🔺) 42 ms
thirdweb/react (minimal + tree-shaking) 19.14 KB (0%) 383 ms (0%) 95 ms (+805.19% 🔺) 478 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 29, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the styles for links within the `changelog-page` in the `styles.css` file, specifically removing certain text decoration properties.

### Detailed summary
- Removed the text decoration properties (`text-decoration`, `text-decoration-color`, `text-decoration-style`, `text-underline-offset`, `transition`) from the `.changelog-page a` selector.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Style**
  * Updated link appearance on the changelog page for consistency with global styles. Regular links no longer use custom underlines or color transitions, resulting in a cleaner look and improved readability. Headings remain without underlines, and hover behavior is unchanged. Users should notice a more consistent visual experience across the page without functional changes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 09-30-portal_remove_underlines_from_links_in_changelog_page branch from 2326b75 to 0c7149e Compare September 29, 2025 23:48
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 29, 2025 23:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 29, 2025 23:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 29, 2025 23:48 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula September 29, 2025 23:48 Inactive
@graphite-app graphite-app bot merged commit 0c7149e into main Sep 30, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 09-30-portal_remove_underlines_from_links_in_changelog_page branch September 30, 2025 00:27
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 30, 2025 00:27 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui September 30, 2025 00:27 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www September 30, 2025 00:27 Inactive
@vercel vercel bot temporarily deployed to Production – nebula September 30, 2025 00:27 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 September 30, 2025 00:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants