Dashboard: Disable pay modal in ERC1155 set claim conditions if cost estimation is already done in dashboard #8161
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
WalkthroughUpdated handleSetClaimConditionsERC1155 to route multi-batch transactions to the no-pay modal flow when a wallet is present; single-batch (or no-wallet) transactions continue to use the standard pay flow. A fallback to the standard flow exists if the no-pay modal path errors. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant UI as CreateNFT Page
participant W as Wallet
participant TX as Tx Sender
U->>UI: Set claim conditions (ERC1155)
UI->>UI: Validate funds, prepare batches (totalBatches)
alt totalBatches > 1 and wallet present
UI->>TX: sendAndConfirmTxNoPayModal.mutateAsync(tx)
note right of TX #DDFFDD: No-pay modal path for batched tx
TX-->>UI: Result / Error
opt Fallback on error
UI->>TX: sendAndConfirmTx.mutateAsync(tx)
TX-->>UI: Result / Error
end
else Single batch or no wallet
UI->>TX: sendAndConfirmTx.mutateAsync(tx)
TX-->>UI: Result / Error
end
UI-->>U: Success / Failure
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (5)**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
apps/{dashboard,playground-web}/**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
apps/{dashboard,playground}/**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/{dashboard,playground}/**/*.tsx📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (1)📚 Learning: 2025-06-10T00:46:00.514ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8161 +/- ##
=======================================
Coverage 56.28% 56.28%
=======================================
Files 906 906
Lines 59208 59208
Branches 4180 4180
=======================================
Hits 33324 33324
Misses 25779 25779
Partials 105 105
🚀 New features to boost your workflow:
|
size-limit report 📦
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/create-nft-page.tsx (2)
331-336: Multi-batch no‑pay path: LGTM. Add fallback on late insufficient‑funds errors.The routing to no‑pay flow for multi‑batch runs aligns with the PR objective. To protect UX if gas spikes after the first‑batch precheck, fall back to the pay‑modal path only on “insufficient funds” errors.
- await sendAndConfirmTxNoPayModal.mutateAsync(tx); - } else if (totalBatches > 1) { - await sendAndConfirmTxNoPayModal.mutateAsync(tx); - } else { - await sendAndConfirmTx.mutateAsync(tx); - } + await sendAndConfirmTxNoPayModal.mutateAsync(tx); + } else if (totalBatches > 1) { + try { + await sendAndConfirmTxNoPayModal.mutateAsync(tx); + } catch (err) { + // Fallback only when clearly insufficient funds; keep other errors intact + const msg = String((err as any)?.message ?? (err as any)?.shortMessage ?? err); + if (/insufficient funds/i.test(msg)) { + await sendAndConfirmTx.mutateAsync(tx); + } else { + throw err; + } + } + } else { + await sendAndConfirmTx.mutateAsync(tx); + }Nit: you can also dedupe the two no‑pay calls by computing a
const useNoPay = totalBatches > 1and invoking the chosen mutate once after the first‑batch precheck.
301-321: Precheck math may overestimate when the last batch is smaller; use a ceil’d remainder split (and guard batch size).Multiplying a single‑batch estimate by
totalBatchescan overestimate when the final batch has fewer items, potentially blocking valid submits. Consider accounting for the remainder with a ceil’d proportional cost, and add a simple guard forbatch.count.- const totalBatches = Math.ceil(values.nfts.length / batch.count); + if (batch.count <= 0) { + throw new Error("Invalid batch size"); + } + const totalBatches = Math.ceil(values.nfts.length / batch.count); - const totalCost = costPerBatch * BigInt(totalBatches); + const remainder = values.nfts.length % batch.count; + const totalCost = + remainder === 0 + ? costPerBatch * BigInt(totalBatches) + : // (totalBatches - 1) full batches + ceil(costPerBatch * remainder/count) + costPerBatch * BigInt(totalBatches - 1) + + ((costPerBatch * BigInt(remainder) + BigInt(batch.count) - 1n) / BigInt(batch.count));This keeps the check conservative (ceil) while reducing false negatives for users with just‑enough balance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/create-nft-page.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/create-nft-page.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/create-nft-page.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/*(Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
UseNavLinkfor internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Usecn()from@/lib/utilsfor conditional class logic
Use design system tokens (e.g.,bg-card,border-border,text-muted-foreground)
Server Components (Node edge): Start files withimport "server-only";
Client Components (browser): Begin files with'use client';
Always callgetAuthToken()to retrieve JWT from cookies on server side
UseAuthorization: Bearerheader – never embed tokens in URLs
Return typed results (e.g.,Project[],User[]) – avoidany
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stablequeryKeysfor React Query cache hits
ConfigurestaleTime/cacheTimein React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never importposthog-jsin server components
Files:
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/create-nft-page.tsx
apps/{dashboard,playground}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
apps/{dashboard,playground}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/_(e.g., Button, Input, Tabs, Card)
UseNavLinkfor internal navigation to get active state handling
Use Tailwind CSS for styling; no inline styles
Merge class names withcn()from@/lib/utilsfor conditional classes
Stick to design tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components must start withimport "server-only"; usenext/headers, server‑only env, heavy data fetching, andredirect()where appropriate
Client Components must start with'use client'; handle interactivity with hooks and browser APIs
Server-side data fetching: callgetAuthToken()from cookies, sendAuthorization: Bearer <token>header, and return typed results (avoidany)
Client-side data fetching: wrap calls in React Query with descriptive, stablequeryKeysand set sensiblestaleTime/cacheTime(≥ 60s default); keep tokens secret via internal routes or server actions
Do not importposthog-jsin server components (client-side only)
Files:
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/create-nft-page.tsx
apps/{dashboard,playground}/**/*.tsx
📄 CodeRabbit inference engine (AGENTS.md)
Expose a
classNameprop on the root element of every component
Files:
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/create-nft-page.tsx
🧠 Learnings (1)
📚 Learning: 2025-06-10T00:46:00.514Z
Learnt from: MananTank
PR: thirdweb-dev/js#7315
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/assets/create/nft/form.ts:25-42
Timestamp: 2025-06-10T00:46:00.514Z
Learning: In NFT creation functions, the setClaimConditions function signatures are intentionally different between ERC721 and ERC1155. ERC721 setClaimConditions accepts the full CreateNFTFormValues, while ERC1155 setClaimConditions accepts a custom object with nftCollectionInfo and nftBatch parameters because it processes batches differently than the entire form data.
Applied to files:
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/create-nft-page.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
Merge activity
|
…estimation is already done in dashboard (#8161) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the logic for handling transaction confirmations in the `create-nft-page.tsx` file, specifically addressing scenarios with multiple batches. ### Detailed summary - Added a conditional check for `totalBatches > 1`. - If true, it uses `sendAndConfirmTxNoPayModal.mutateAsync(tx)` for transaction confirmation. - If false, it defaults to `sendAndConfirmTx.mutateAsync(tx)` for single batch transactions. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Streamlined multi-batch transaction confirmation when configuring NFT claim conditions. When multiple batches are required and a wallet is connected, a no-payment confirmation modal is used to reduce prompts and improve reliability. Single-batch flows continue to use the standard confirmation path. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
10-01-dashboard_disable_pay_modal_in_erc1155_set_claim_conditions_if_cost_estimation_is_already_done_in_dashboard
branch
from
4fd18e4 to
dbadc23
Compare
graphite-app
bot
deleted the
10-01-dashboard_disable_pay_modal_in_erc1155_set_claim_conditions_if_cost_estimation_is_already_done_in_dashboard
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
PR-Codex overview
This PR focuses on updating the transaction confirmation logic in the
create-nft-page.tsxfile, specifically handling different scenarios based on the number of batches in the transaction.Detailed summary
else ifcondition to check iftotalBatchesis greater than 1.sendAndConfirmTxNoPayModal.mutateAsync(tx)for both the new condition and the originalelsecase whentotalBatchesis 1 or less.Summary by CodeRabbit