Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Sep 30, 2025

TL;DR

Added a new rewrite rule for the /payments/x402 path in the dashboard app.

What changed?

Added /payments/x402 to the list of rewrite paths in the framer-rewrites.js file. This allows the dashboard app to properly handle and route requests to this new payments path.

How to test?

  1. Navigate to the /payments/x402 route in the dashboard app
  2. Verify that the page loads correctly and follows the expected rewrite behavior
  3. Ensure that existing payment routes continue to function as expected

Why make this change?

This change supports a new payments feature or section identified as "x402" that needs to be accessible through the dashboard. Adding the rewrite rule ensures proper routing and functionality for this new payments path.

Summary by CodeRabbit

  • New Features
    • Introduced a new Payments route at /payments/x402, enabling direct access to the X402 payments screen via URL and bookmarks.
    • Improves navigation and deep-linking within the dashboard by expanding available payments routes.

@vercel vercel bot temporarily deployed to Preview – nebula September 30, 2025 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 30, 2025 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 30, 2025 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 30, 2025 22:27 Inactive
@vercel
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Sep 30, 2025 10:35pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Sep 30, 2025 10:35pm
nebula Skipped Skipped Sep 30, 2025 10:35pm
thirdweb_playground Skipped Skipped Sep 30, 2025 10:35pm
wallet-ui Skipped Skipped Sep 30, 2025 10:35pm

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2025

⚠️ No Changeset found

Latest commit: f825cb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Added a new route string "/payments/x402" to the exported rewrites array in apps/dashboard/framer-rewrites.js.

Changes

Cohort / File(s) Change Summary
Framer rewrites config
apps/dashboard/framer-rewrites.js
Appended route "/payments/x402" to the exported array (module.exports = [ ... ]).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Add_/payments/x402_to_framer-rewrites

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 27d5a81 and f825cb1.

📒 Files selected for processing (1)
  • apps/dashboard/framer-rewrites.js (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 30, 2025
@jnsdls jnsdls marked this pull request as ready for review September 30, 2025 22:27
@jnsdls jnsdls requested review from a team as code owners September 30, 2025 22:27
Copy link
Member Author

jnsdls commented Sep 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls merged commit 90c1e57 into main Sep 30, 2025
21 of 23 checks passed
@jnsdls jnsdls deleted the Add_/payments/x402_to_framer-rewrites branch September 30, 2025 22:27
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.28%. Comparing base (27d5a81) to head (f825cb1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8165   +/-   ##
=======================================
  Coverage   56.28%   56.28%           
=======================================
  Files         906      906           
  Lines       59208    59208           
  Branches     4180     4180           
=======================================
  Hits        33324    33324           
  Misses      25779    25779           
  Partials      105      105           
Flag Coverage Δ
packages 56.28% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.69 KB (0%) 1.3 s (0%) 218 ms (+115.87% 🔺) 1.6 s
thirdweb (cjs) 361.52 KB (0%) 7.3 s (0%) 782 ms (+3.24% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 91 ms (+2032.87% 🔺) 206 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 39 ms (+1269.54% 🔺) 49 ms
thirdweb/react (minimal + tree-shaking) 19.14 KB (0%) 383 ms (0%) 74 ms (+2002.3% 🔺) 457 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants