Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Sep 30, 2025


PR-Codex overview

This PR updates the API endpoint used in the useEngine hook to fetch the status of a transaction instead of fetching the transaction details.

Detailed summary

  • Changed the fetch URL from ${instanceUrl}transaction/${id} to ${instanceUrl}transaction/status/${id} in the queryFn function of the useEngine hook.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Improved reliability when viewing the status of an individual transaction.
  • Chores

    • Updated the backend route used for single-transaction status retrieval to align with current server expectations. No changes to request method, headers, response format, or UI.
    • Minor internal formatting cleanup with no user-facing impact.

@vercel vercel bot temporarily deployed to Preview – wallet-ui September 30, 2025 23:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 30, 2025 23:09 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula September 30, 2025 23:09 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2025

⚠️ No Changeset found

Latest commit: 1861059

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Sep 30, 2025 11:18pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Sep 30, 2025 11:18pm
nebula Skipped Skipped Sep 30, 2025 11:18pm
thirdweb_playground Skipped Skipped Sep 30, 2025 11:18pm
wallet-ui Skipped Skipped Sep 30, 2025 11:18pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 30, 2025 23:09 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The hook useEngine updated the API endpoint for fetching a single transaction by id from /transaction/{id} to /transaction/status/{id}. No other request parameters or JSON handling logic changed. A minor formatting cleanup removed an empty line.

Changes

Cohort / File(s) Summary of modifications
Dashboard engine hook
apps/dashboard/src/@/hooks/useEngine.ts
Updated fetch URL for single-transaction retrieval to /transaction/status/{id}; no changes to headers/method or JSON handling. Minor whitespace cleanup.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant UI as Dashboard (useEngine hook)
  participant API as Backend API

  UI->>API: GET /transaction/status/{id}
  API-->>UI: 200 OK + JSON (transaction status)
  note over UI,API: Path updated from /transaction/{id} to /transaction/status/{id}
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch _Dashboard_Update_transaction_status_endpoint_path

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4c51fe6 and 1861059.

📒 Files selected for processing (1)
  • apps/dashboard/src/@/hooks/useEngine.ts (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@joaquim-verges joaquim-verges marked this pull request as ready for review September 30, 2025 23:09
@joaquim-verges joaquim-verges requested a review from a team as a code owner September 30, 2025 23:09
@joaquim-verges joaquim-verges requested a review from a team as a code owner September 30, 2025 23:09
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 30, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges merged commit e11b0da into main Sep 30, 2025
21 of 23 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Update_transaction_status_endpoint_path branch September 30, 2025 23:10
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.28%. Comparing base (4c51fe6) to head (1861059).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8166   +/-   ##
=======================================
  Coverage   56.28%   56.28%           
=======================================
  Files         906      906           
  Lines       59208    59208           
  Branches     4180     4180           
=======================================
  Hits        33324    33324           
  Misses      25779    25779           
  Partials      105      105           
Flag Coverage Δ
packages 56.28% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.69 KB (0%) 1.3 s (0%) 113 ms (+136.83% 🔺) 1.5 s
thirdweb (cjs) 361.52 KB (0%) 7.3 s (0%) 514 ms (+6.62% 🔺) 7.8 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 45 ms (+578.59% 🔺) 159 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 5 ms (+25.6% 🔺) 15 ms
thirdweb/react (minimal + tree-shaking) 19.14 KB (0%) 383 ms (0%) 69 ms (+2282.8% 🔺) 452 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants