Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 9, 2025


PR-Codex overview

This PR updates the token statistics in the dashboard and bridge pages, reflecting an increase in supported tokens. It also enhances the TokensTable component by adding a new button for buying tokens and improving the layout with additional table headers and cells.

Detailed summary

  • Updated token count from 3200+ to 4500+ in the dashboard and bridge pages.
  • Modified description in the bridge page to reflect the new token count.
  • Added an empty <TableHead> in the TokensTable component.
  • Added a new <TableCell> with a <Skeleton> for loading state.
  • Enhanced TokensTable with a button for buying tokens, including a link to the token's page.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Added a Buy action column with a button in the tokens table; skeleton placeholders updated for alignment.
  • Style

    • Rounded token avatars for a refined look.
    • Simplified token name display by removing inline linking.
  • Documentation

    • Updated copy to reflect “4500+ tokens” across the tokens and bridge pages (headers, descriptions, and UI labels).

@MananTank MananTank marked this pull request as ready for review October 9, 2025 15:22
@MananTank MananTank requested review from a team as code owners October 9, 2025 15:22
Copy link
Member Author

MananTank commented Oct 9, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Oct 9, 2025

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025

⚠️ No Changeset found

Latest commit: 6fc4d83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2025 15:29 Inactive
@vercel
Copy link

vercel bot commented Oct 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Oct 9, 2025 6:51pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Oct 9, 2025 6:51pm
nebula Skipped Skipped Oct 9, 2025 6:51pm
thirdweb_playground Skipped Skipped Oct 9, 2025 6:51pm
wallet-ui Skipped Skipped Oct 9, 2025 6:51pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2025 15:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2025 15:29 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 9, 2025 15:29 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 9, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

Walkthrough

Adds a dedicated “Buy” action column to the tokens table with conditional navigation targets, adjusts header and skeleton to match the new column, tweaks avatar styling, removes the inline name link in favor of plain text, and updates copy to reflect “4500+ tokens” on tokens and bridge pages.

Changes

Cohort / File(s) Summary of Changes
Tokens table UI & actions
apps/dashboard/src/app/(app)/(dashboard)/tokens/components/tokens-table.tsx
Added an extra header/action column with a “Buy” button that links to either the native token page or the token address page depending on token type; updated skeleton rendering to include an extra placeholder cell; added rounded-full to AvatarImage; removed Link wrapping token name and replaced with plain text.
Token count copy updates
apps/dashboard/src/app/(app)/(dashboard)/tokens/page.tsx, apps/dashboard/src/app/bridge/page.tsx
Updated displayed token counts and related copy from “3200+” to “4500+” (page text, description, and DataPill label).

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant TokensTable as TokensTable (UI)
  participant Router as Link/Router
  participant NativePage as Native Token Page
  participant AddressPage as Token Address Page

  User->>TokensTable: Click "Buy" button
  TokensTable->>Router: Navigate to target (isNative ? native route : address route)
  alt Token is native
    Router->>NativePage: Open native token page
    Note right of NativePage: Show native token purchase flow
  else Token is not native
    Router->>AddressPage: Open token address page
    Note right of AddressPage: Show token address purchase flow
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description retains the template placeholder comments and does not populate the required “Notes for the reviewer” or “How to test” sections, instead providing a PR-Codex overview without the structured guidance expected by the repository template. Please fill in the “Notes for the reviewer” and “How to test” sections according to the repository template, providing important context for reviewers and clear steps to verify the changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title uses the issue tag and dashboard prefix, concisely describes the primary changes—adding a Buy button in the tokens table and updating the supported token count—and accurately reflects the content of the changeset without including extraneous details.
Linked Issues Check ✅ Passed The changes directly implement the quick-win UI enhancement suggested in issue MNY-246 by adding a Buy button in the tokens table and updating the supported token counts, thereby aligning with the objective to improve conversion and purchases.
Out of Scope Changes Check ✅ Passed All modifications—including the extra header column, skeleton alignment, avatar styling update, supported token count text changes, and the new Buy button—relate directly to enhancing the tokens table and updating supported token information, with no unrelated code changes introduced.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mny-246

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between eb0f428 and 6fc4d83.

📒 Files selected for processing (3)
  • apps/dashboard/src/app/(app)/(dashboard)/tokens/components/tokens-table.tsx (5 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/tokens/page.tsx (1 hunks)
  • apps/dashboard/src/app/bridge/page.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/dashboard/src/app/bridge/page.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/tokens/components/tokens-table.tsx
  • apps/dashboard/src/app/(app)/(dashboard)/tokens/page.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Size
  • GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.02%. Comparing base (fe940b3) to head (6fc4d83).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8222   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files         919      919           
  Lines       60583    60583           
  Branches     4126     4126           
=======================================
  Hits        33333    33333           
  Misses      27146    27146           
  Partials      104      104           
Flag Coverage Δ
packages 55.02% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.51 KB (0%) 1.3 s (0%) 228 ms (+167.33% 🔺) 1.6 s
thirdweb (cjs) 365.79 KB (0%) 7.4 s (0%) 785 ms (+9.91% 🔺) 8.2 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 90 ms (+1931.21% 🔺) 204 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 88 ms (+2638.25% 🔺) 98 ms
thirdweb/react (minimal + tree-shaking) 19.13 KB (0%) 383 ms (0%) 89 ms (+1844.6% 🔺) 471 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 9, 2025

Merge activity

… tokens count (#8222)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating token-related information and enhancing the `TokensTable` component in the dashboard, including the increase in the number of supported tokens and the addition of a buy button for each token.

### Detailed summary
- Updated token count from `3200+` to `4500+` in `page.tsx`.
- Changed description in `page.tsx` to reflect the new token count.
- Modified `TokensTable` to display the updated token count.
- Added a new button in `TokensTable` for buying tokens, including a link to the token's page.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- New Features
  - Added a Buy action column with a button in the tokens table, including proper skeleton alignment for the new column.

- Style
  - Rounded token avatars for a refined look.
  - Simplified token name display by removing inline linking.

- Documentation
  - Updated copy to reflect “4500+ tokens” on the tokens page and bridge page, including Open Graph/description and UI labels.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 9, 2025 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 9, 2025 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 9, 2025 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 9, 2025 18:42 Inactive
@graphite-app graphite-app bot merged commit 6fc4d83 into main Oct 9, 2025
24 checks passed
@graphite-app graphite-app bot deleted the mny-246 branch October 9, 2025 18:51
@vercel vercel bot temporarily deployed to Production – nebula October 9, 2025 18:51 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 9, 2025 18:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants