SDK: Fix process not defined error in Vite #8280

MananTank · 2025-10-20T12:32:07Z

PR-Codex overview

This PR addresses an issue where a process not defined error occurred when using the thirdweb/contract import in Vite. It modifies the way the PUBLISHED_PRIVATE_KEY is exported to ensure compatibility.

Detailed summary

Updated PUBLISHED_PRIVATE_KEY export to check if process is defined before accessing process.env.ZKSYNC_PUBLISHED_PRIVATE_KEY.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Chores
- Improved environment configuration handling to be more robust in non-Node environments, reducing unexpected runtime errors when the library is imported in diverse build setups.
Bug Fixes
- Resolved a "process not defined" error that could occur during import in certain bundlers (e.g., Vite); included as a patch release to improve compatibility and stability.

vercel · 2025-10-20T12:32:08Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs-v2	Ready	Preview	Comment	Oct 20, 2025 2:05pm
nebula	Ready	Preview	Comment	Oct 20, 2025 2:05pm
thirdweb_playground	Ready	Preview	Comment	Oct 20, 2025 2:05pm
thirdweb-www	Ready	Preview	Comment	Oct 20, 2025 2:05pm
wallet-ui	Ready	Preview	Comment	Oct 20, 2025 2:05pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

changeset-bot · 2025-10-20T12:32:11Z

🦋 Changeset detected

Latest commit: ceba683

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/nebula	Patch
@thirdweb-dev/wagmi-adapter	Patch
wagmi-inapp	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

MananTank · 2025-10-20T12:32:26Z

SDK: Fix process not defined error in Vite #8280 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai · 2025-10-20T12:32:35Z

Walkthrough

The PUBLISHED_PRIVATE_KEY constant initializer was hardened to safely detect and read process.env by adding explicit checks (typeof process !== "undefined", process, and process.env) instead of a simple truthiness check; a changeset file was also added for a patch release documenting the fix.

Changes

Cohort / File(s)	Change Summary
Environment variable access hardening `packages/thirdweb/src/utils/any-evm/zksync/constants.ts`	Strengthened `PUBLISHED_PRIVATE_KEY` initializer to use `typeof process !== "undefined" && process && process.env ? process.env.ZKSYNC_PUBLISHED_PRIVATE_KEY : undefined`, preventing runtime "process not defined" errors in non-Node environments.
Release metadata `.changeset/small-taxes-heal.md`	Added changeset documenting a patch release that fixes the "process not defined" error when importing `thirdweb/contract` in Vite.

Sequence Diagram(s)

(omitted — changes are a small constant initializer and a metadata file; no control-flow changes warranting a sequence diagram)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description does not follow the repository's template structure. While a PR-Codex auto-generated overview is included that provides context about the fix, the required template sections remain unfilled—specifically, the "Notes for the reviewer" and "How to test" sections are left as template comments with no actual content. Additionally, no Linear issue tag (TEAM-0000 format) is provided despite the template requesting it. The PR-Codex overview alone, while helpful, does not substitute for the structured information requested in the template.	Complete the PR description by filling out the required template sections. Provide the Linear issue tag (TEAM-0000), add relevant notes for reviewers that call out any important considerations or implications of the fix, and clearly document how to test the changes (e.g., which unit tests, playground scenarios, or manual verification steps should be performed to validate the fix works in Vite).

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "SDK: Fix process not defined error in Vite" clearly and concisely summarizes the main change in the changeset. It identifies the component (SDK), the type of change (Fix), and the specific issue being resolved (process not defined error in Vite), which directly aligns with the core modification to PUBLISHED_PRIVATE_KEY to guard against undefined process objects. The title is specific enough that teammates scanning history would understand the primary purpose of the change without ambiguity.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 10-20-sdk_fix_process_not_defined_error

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 22e4db7 and ceba683.

📒 Files selected for processing (2)

.changeset/small-taxes-heal.md (1 hunks)
packages/thirdweb/src/utils/any-evm/zksync/constants.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.changeset/small-taxes-heal.md

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from @/types where applicable
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size

Files:

packages/thirdweb/src/utils/any-evm/zksync/constants.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

packages/thirdweb/src/utils/any-evm/zksync/constants.ts

packages/thirdweb/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

packages/thirdweb/**/*.{ts,tsx}: Every public symbol must have comprehensive TSDoc with at least one compiling @example and a custom tag (@beta, @internal, @experimental, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
Lazy‑load heavy dependencies inside async paths (e.g., const { jsPDF } = await import("jspdf"))

Files:

packages/thirdweb/src/utils/any-evm/zksync/constants.ts

🪛 GitHub Check: codecov/patch

packages/thirdweb/src/utils/any-evm/zksync/constants.ts

[warning] 9-9: packages/thirdweb/src/utils/any-evm/zksync/constants.ts#L9
Added line #L9 was not covered by tests

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Size
GitHub Check: Lint Packages
GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b33c1a3 and 0232b45.

📒 Files selected for processing (1)

packages/thirdweb/src/utils/any-evm/zksync/constants.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from @/types where applicable
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size

Files:

packages/thirdweb/src/utils/any-evm/zksync/constants.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

packages/thirdweb/src/utils/any-evm/zksync/constants.ts

packages/thirdweb/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

packages/thirdweb/**/*.{ts,tsx}: Every public symbol must have comprehensive TSDoc with at least one compiling @example and a custom tag (@beta, @internal, @experimental, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
Lazy‑load heavy dependencies inside async paths (e.g., const { jsPDF } = await import("jspdf"))

Files:

packages/thirdweb/src/utils/any-evm/zksync/constants.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: Size
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Unit Tests
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Lint Packages
GitHub Check: Build Packages
GitHub Check: Analyze (javascript)

packages/thirdweb/src/utils/any-evm/zksync/constants.ts

codecov · 2025-10-20T12:38:29Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.89%. Comparing base (b33c1a3) to head (ceba683).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ges/thirdweb/src/utils/any-evm/zksync/constants.ts	50.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8280   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files         919      919           
  Lines       60622    60623    +1     
  Branches     4115     4116    +1     
=======================================
+ Hits        33277    33282    +5     
+ Misses      27244    27240    -4     
  Partials      101      101

Flag	Coverage Δ
packages	`54.89% <50.00%> (+<0.01%)`	⬆️

Files with missing lines	Coverage Δ
...ges/thirdweb/src/utils/any-evm/zksync/constants.ts	`95.23% <50.00%> (+0.11%)`	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-10-20T12:39:23Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	64.51 KB (0%)	1.3 s (0%)	143 ms (+133.42% 🔺)	1.5 s
thirdweb (cjs)	365.68 KB (0%)	7.4 s (0%)	564 ms (+4.5% 🔺)	7.9 s
thirdweb (minimal + tree-shaking)	5.73 KB (0%)	115 ms (0%)	69 ms (+3228.48% 🔺)	184 ms
thirdweb/chains (tree-shaking)	526 B (0%)	11 ms (0%)	93 ms (+6932.83% 🔺)	104 ms
thirdweb/react (minimal + tree-shaking)	19.13 KB (0%)	383 ms (0%)	65 ms (+2352.8% 🔺)	447 ms

graphite-app · 2025-10-20T13:54:41Z

Merge activity

Oct 20, 1:54 PM UTC: MananTank added this pull request to the Graphite merge queue.
Oct 20, 2:05 PM UTC: Merged by the Graphite merge queue.

--- ## PR-Codex overview This PR addresses a `process not defined` error that occurs when using the `thirdweb/contract` import in Vite by ensuring that the `process` variable is only accessed when it is defined. ### Detailed summary - Updated `PUBLISHED_PRIVATE_KEY` export in `packages/thirdweb/src/utils/any-evm/zksync/constants.ts` to check if `process` is defined before accessing `process.env.ZKSYNC_PUBLISHED_PRIVATE_KEY`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit - **Chores** - Improved robustness of environment configuration handling to avoid runtime issues in non-Node environments. - **Bug Fixes** - Fixed a "process not defined" error that could occur when importing the library in Vite, included in a patch release.

github-actions bot assigned MananTank Oct 20, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Oct 20, 2025

MananTank marked this pull request as ready for review October 20, 2025 12:32

MananTank requested review from a team as code owners October 20, 2025 12:32

coderabbitai bot reviewed Oct 20, 2025

View reviewed changes

packages/thirdweb/src/utils/any-evm/zksync/constants.ts Show resolved Hide resolved

vercel bot deployed to Preview – nebula October 20, 2025 12:36 View deployment

0xFirekeeper approved these changes Oct 20, 2025

View reviewed changes

vercel bot deployed to Preview – wallet-ui October 20, 2025 12:39 View deployment

vercel bot deployed to Preview – thirdweb-www October 20, 2025 12:41 View deployment

MananTank force-pushed the 10-20-sdk_fix_process_not_defined_error branch from 0232b45 to 22e4db7 Compare October 20, 2025 12:43

MananTank changed the title ~~SDK: Fix process not defined error~~ SDK: Fix process not defined error in Vite Oct 20, 2025

vercel bot deployed to Preview – nebula October 20, 2025 12:45 View deployment

vercel bot deployed to Preview – thirdweb-www October 20, 2025 12:52 View deployment

vercel bot deployed to Preview – docs-v2 October 20, 2025 12:57 View deployment

vercel bot deployed to Preview – wallet-ui October 20, 2025 12:57 View deployment

vercel bot deployed to Preview – thirdweb_playground October 20, 2025 12:58 View deployment

graphite-app bot force-pushed the 10-20-sdk_fix_process_not_defined_error branch from 22e4db7 to ceba683 Compare October 20, 2025 13:55

vercel bot deployed to Preview – nebula October 20, 2025 13:56 View deployment

vercel bot deployed to Preview – thirdweb-www October 20, 2025 14:01 View deployment

vercel bot deployed to Preview – docs-v2 October 20, 2025 14:03 View deployment

vercel bot deployed to Preview – wallet-ui October 20, 2025 14:04 View deployment

vercel bot deployed to Preview – thirdweb_playground October 20, 2025 14:05 View deployment

graphite-app bot merged commit ceba683 into main Oct 20, 2025
23 of 24 checks passed

graphite-app bot deleted the 10-20-sdk_fix_process_not_defined_error branch October 20, 2025 14:05

joaquim-verges mentioned this pull request Oct 20, 2025

Version Packages #8281

Merged

vercel bot deployed to Production – nebula October 20, 2025 14:09 View deployment

vercel bot deployed to Production – thirdweb-www October 20, 2025 14:13 View deployment

vercel bot deployed to Production – thirdweb_playground October 20, 2025 14:15 View deployment

vercel bot deployed to Production – wallet-ui October 20, 2025 14:18 View deployment

vercel bot deployed to Production – docs-v2 October 20, 2025 14:30 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SDK: Fix process not defined error in Vite #8280

SDK: Fix process not defined error in Vite #8280

Uh oh!

MananTank commented Oct 20, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

MananTank commented Oct 20, 2025

Uh oh!

coderabbitai bot commented Oct 20, 2025 •

edited

Loading

Review ran into problems

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

codecov bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SDK: Fix process not defined error in Vite #8280

SDK: Fix process not defined error in Vite #8280

Uh oh!

Conversation

MananTank commented Oct 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

vercel bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

MananTank commented Oct 20, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Pre-merge checks and finishing touches

Review ran into problems

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Oct 20, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Oct 20, 2025 •

edited

Loading

changeset-bot bot commented Oct 20, 2025 •

edited

Loading

coderabbitai bot commented Oct 20, 2025 •

edited

Loading

codecov bot commented Oct 20, 2025 •

edited

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading

graphite-app bot commented Oct 20, 2025 •

edited

Loading