Skip to content

Conversation

@lmorett1
Copy link

@lmorett1 lmorett1 commented Nov 3, 2025

  • Fixes multiple typos across docs/comments/log text:

    • "conjuction" → "conjunction"
    • "specfiy" → "specify"
    • "occured" → "occurred"
    • "servive" → "service"
    • "pacakges" → "packages"

PR-Codex overview

This PR focuses on correcting typographical errors and improving the clarity of documentation across various files in the codebase.

Detailed summary

  • Fixed spelling of service in packages/vault-sdk/README.md.
  • Corrected spelling of specify in apps/portal/src/app/wallets/link-profiles/page.mdx.
  • Fixed spelling of packages in scripts/hotlink/hotlink-init.mjs.
  • Corrected spelling of occurred in apps/portal/src/app/webhooks/page.mdx.
  • Fixed spelling of conjunction in apps/portal/public/llms-full.txt.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Documentation
    • Fixed multiple spelling errors and grammatical inconsistencies across documentation and code comments.
    • Enhanced descriptions for improved clarity and accuracy.

@lmorett1 lmorett1 requested review from a team, jnsdls and joaquim-verges as code owners November 3, 2025 15:05
@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025

⚠️ No Changeset found

Latest commit: 0a790fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 3, 2025

@lmorett1 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages labels Nov 3, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

Walkthrough

Typo corrections and documentation clarifications across five files. Changes include correcting spelling errors ("sepcify" → "specify", "occured" → "occurred", "servive" → "service", "pacak(es)" → "packages") and expanding documentation segments for clarity. No functional code modifications.

Changes

Cohort / File(s) Summary
Portal Documentation Typos
apps/portal/public/llms-full.txt, apps/portal/src/app/wallets/link-profiles/page.mdx, apps/portal/src/app/webhooks/page.mdx
Corrected typos ("conjunction", "specify", "occurred") and expanded clarification on getApprovalForTransaction function usage in transaction flow
SDK and Script Typos
packages/vault-sdk/README.md, scripts/hotlink/hotlink-init.mjs
Fixed typos in README description ("service") and log message ("packages")

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward typo verification across documentation and non-functional code comments
  • No logic, control flow, or behavioral changes to validate
  • One file (llms-full.txt) marked for skip review

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description provides a clear bullet-point list of all typos fixed, which directly corresponds to the changes made in the files. However, the description does not follow the required template format specified in the repository, which calls for sections like 'Notes for the reviewer' and 'How to test'. The PR-Codex summary adds useful context but cannot substitute for the template structure. The description is largely complete in terms of content but fails to adhere to the structural requirements. Restructure the PR description to follow the repository template, including sections for 'Notes for the reviewer' and 'How to test'. While the bullet list of typos is helpful, it should be incorporated within the template framework. Additionally, add the Linear issue tag (format TEAM-0000) if applicable to this PR.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'docs: typo fixes' directly and accurately summarizes the main purpose of the changeset. The title clearly communicates that this PR addresses documentation and typo corrections across multiple files, which aligns perfectly with the actual changes made. The title is concise, specific, and scannable for someone reviewing PR history.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2725f33 and 0a790fd.

📒 Files selected for processing (5)
  • apps/portal/public/llms-full.txt (1 hunks)
  • apps/portal/src/app/wallets/link-profiles/page.mdx (1 hunks)
  • apps/portal/src/app/webhooks/page.mdx (1 hunks)
  • packages/vault-sdk/README.md (1 hunks)
  • scripts/hotlink/hotlink-init.mjs (1 hunks)
🧰 Additional context used
🧠 Learnings (10)
📚 Learning: 2025-06-06T23:47:55.122Z
Learnt from: MananTank
Repo: thirdweb-dev/js PR: 7298
File: apps/dashboard/src/app/nebula-app/move-funds/move-funds.tsx:255-277
Timestamp: 2025-06-06T23:47:55.122Z
Learning: The `transfer` function from `thirdweb/extensions/erc20` accepts human-readable amounts via the `amount` property and automatically handles conversion to base units (wei) by fetching the token decimals internally. Manual conversion using `toWei()` is not required when using the `amount` property.

Applied to files:

  • apps/portal/public/llms-full.txt
📚 Learning: 2025-05-20T18:54:15.781Z
Learnt from: MananTank
Repo: thirdweb-dev/js PR: 7081
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/assets/create/create-token-page-impl.tsx:110-118
Timestamp: 2025-05-20T18:54:15.781Z
Learning: In the thirdweb dashboard's token asset creation flow, the `transferBatch` function from `thirdweb/extensions/erc20` accepts the raw quantity values from the form without requiring explicit conversion to wei using `toUnits()`. The function appears to handle this conversion internally or is designed to work with the values in the format they're already provided.

Applied to files:

  • apps/portal/public/llms-full.txt
📚 Learning: 2025-06-26T19:46:04.024Z
Learnt from: gregfromstl
Repo: thirdweb-dev/js PR: 7450
File: packages/thirdweb/src/bridge/Webhook.ts:57-81
Timestamp: 2025-06-26T19:46:04.024Z
Learning: In the onramp webhook schema (`packages/thirdweb/src/bridge/Webhook.ts`), the `currencyAmount` field is intentionally typed as `z.number()` while other amount fields use `z.string()` because `currencyAmount` represents fiat currency amounts in decimals (like $10.50), whereas other amount fields represent token amounts in wei (very large integers that benefit from bigint representation). The different naming convention (`currencyAmount` vs `amount`) reflects this intentional distinction.

Applied to files:

  • apps/portal/public/llms-full.txt
📚 Learning: 2025-05-20T19:03:35.954Z
Learnt from: MananTank
Repo: thirdweb-dev/js PR: 7081
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/assets/create/create-token-page-impl.tsx:160-165
Timestamp: 2025-05-20T19:03:35.954Z
Learning: The `claimTo` function in Thirdweb's ERC20 extension does not require converting the quantity to the smallest units (using toUnits) as it handles unit conversion internally or works with the units as provided.

Applied to files:

  • apps/portal/public/llms-full.txt
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Lint all packages using `pnpm lint` and auto-fix linting issues with `pnpm fix`

Applied to files:

  • scripts/hotlink/hotlink-init.mjs
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Build all packages using `pnpm build` and specific packages with dependencies using `turbo run build --filter=./packages/*`

Applied to files:

  • scripts/hotlink/hotlink-init.mjs
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Use `pnpm install` (or `pnpm install --ignore-scripts` on Windows) for installing dependencies

Applied to files:

  • scripts/hotlink/hotlink-init.mjs
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: De‑duplicate dependencies across packages via pnpm workspace hoisting

Applied to files:

  • scripts/hotlink/hotlink-init.mjs
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: De-duplicate dependencies across packages through pnpm workspace hoisting

Applied to files:

  • scripts/hotlink/hotlink-init.mjs
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Run `pnpm build` to ensure everything builds after each file change

Applied to files:

  • scripts/hotlink/hotlink-init.mjs
🔇 Additional comments (5)
packages/vault-sdk/README.md (1)

3-3: Typo fix approved.

"servive" → "service" is a correct and helpful documentation improvement.

scripts/hotlink/hotlink-init.mjs (1)

42-42: Typo fix approved.

"pacak(es)" → "packages" corrects the user-facing console message without affecting script behavior.

apps/portal/src/app/webhooks/page.mdx (1)

15-15: Typo fix approved.

"occured" → "occurred" improves the documentation definition clarity.

apps/portal/src/app/wallets/link-profiles/page.mdx (1)

235-235: Typo fix approved.

"sepcify" → "specify" corrects the code comment and improves example clarity.

apps/portal/public/llms-full.txt (1)

51706-51706: Typo fix is correct.

The spelling correction from "conjuction" to "conjunction" is accurate and improves documentation clarity.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants