-
Notifications
You must be signed in to change notification settings - Fork 12
fix: mypy, add comments to examples, remove unused actions #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR refactors the statistical analysis module, enhances tests and workflows, and updates documentation and dependency configurations.
- Adds comprehensive tests for statistical analysis and reporting
- Introduces new CSV export functionality and improvements in Google Drive publishing
- Updates workflow caching and dependency lists to support new test features
Reviewed Changes
| File | Description |
|---|---|
| tests/test_statistical_analysis.py | Adds tests for statistical analysis calculations and graph generation |
| src/cat_ai/statistical_analysis.py | Introduces the StatisticalAnalysis dataclass and computation function |
| src/cat_ai/publish_to_gdrive.py | Updates GDrive publishing to support multiple parent folder IDs |
| tests/test_reporter.py | Revamps reporter tests and replaces error margin summary with formatted summary |
| .github/workflows/* | Adds caching settings and updates artifact upload steps |
| pyproject.toml | Updates dependency groups with new requirements |
| src/cat_ai/reporter.py | Replaces legacy error margin summary with a format_summary method |
| examples/team_recommender/tests/example_1_text_response/test_good_fit_for_project.py | Adds clarifying comments to example test responses |
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/test_statistical_analysis.py:101
- The variable name 'csv' shadows the built-in csv module. Consider renaming it to 'csv_string' or a similar descriptive name.
csv = export_results_to_csv_string(results)
Signed-off-by: Paul Zabelin <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
…atistical analysis tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR fixes mypy issues, enhances documentation in examples, and removes unused actions while also introducing additional tests.
- Updated tests to validate statistical analysis and reporting functionality
- Added and refactored functions for statistical analysis and CSV export
- Modified Google Drive publishing parameters and updated workflows for caching and artifact uploads
Reviewed Changes
| File | Description |
|---|---|
| tests/test_statistical_analysis.py | Added tests for validating statistical analysis computations |
| src/cat_ai/statistical_analysis.py | Introduced StatisticalAnalysis dataclass and corresponding analysis function |
| src/cat_ai/publish_to_gdrive.py | Updated handling of parent folder IDs and environment variables |
| tests/test_reporter.py | Replaced outdated error_margin_summary test with test_format_summary based on analysis |
| examples/team_recommender/tests/example_1_text_response/test_*.py | Added clarifying comments to examples |
| .github/workflows/*.yml | Updated workflows with caching, naming, and artifact uploads |
| src/cat_ai/init.py | Expanded exported symbols to include the new statistical analysis functionality |
| src/cat_ai/reporter.py | Refactored summary formatting to use StatisticalAnalysis objects |
| pyproject.toml | Added new dependencies for matplotlib, pytest-snapshot, and ruff |
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
refactor code add tests