Skip to content

Conversation

@paulz
Copy link
Contributor

@paulz paulz commented Mar 24, 2025

Add proportions_ztest

and compare it with current StatisticalAnalysis

Testing framework updates:

Contributors update:

Dependency update:

@tkersey tkersey requested a review from Copilot March 24, 2025 20:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR, titled "Cat math", updates several test cases related to success rate calculations and sample size estimations, while also adding a new contributor to the project.

  • Updated test parameters and messages in team_recommender tests to refine the numerical boundaries.
  • Added a new test suite for sample size functions and introduced an alternative implementation using a loop.
  • Updated CONTRIBUTORS.md to include a new contributor.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
examples/team_recommender/tests/test_helpers.py Updated test cases and added new tests for success rate and sample size calculations.
CONTRIBUTORS.md Added a new contributor entry.
Comments suppressed due to low confidence (1)

examples/team_recommender/tests/test_helpers.py:118

  • The test tuple uses a success rate value of 0.9997 (99.97%) while the accompanying message states 99.99%; please update one of these to ensure clarity and consistency.
(1, 50000, 0.9997, "99.99% success rate is below expected 97% success rate"),

@tkersey tkersey requested a review from Copilot March 24, 2025 23:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request, titled "Cat math", introduces additional tests for statistical functions related to proportions z-test calculations and augments helper functions for sample size estimation.

  • Adds comprehensive tests to validate proportions z-test outcomes under various scenarios.
  • Introduces helper functions for determining the next sample size along with corresponding tests.
  • Updates dependency configuration (pyproject.toml) and contributors list.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

File Description
examples/team_recommender/tests/test_proportions_ztest.py Adds new tests for proportions z-test functionality with various statistical scenarios.
examples/team_recommender/tests/test_helpers.py Introduces helper functions and tests related to sample size calculations.
CONTRIBUTORS.md Updates contributors list by adding a new contributor.
pyproject.toml Adds a new dependency required for statistical computations.

@paulz paulz marked this pull request as ready for review March 25, 2025 00:03
@paulz paulz changed the title Cat math add proportions_ztest to test examples Mar 25, 2025
@carl
Copy link
Contributor

carl commented Mar 25, 2025

🐻 approved

@paulz paulz merged commit a56e21a into thisisartium:main Mar 25, 2025
1 check passed
@paulz paulz deleted the cat-math branch March 25, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants