Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import os
from cat_ai.reporter import Reporter
from cat_ai.runner import Runner
from pyparsing import empty
from tests.settings import ROOT_DIR
from openai import OpenAI

Expand Down
2 changes: 1 addition & 1 deletion src/cat_ai/reporter.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class Reporter:

@staticmethod
def _create_unique_id_from_time() -> str:
return datetime.now().strftime("%Y%m%d_%H%M%S")
return datetime.now().strftime("%m%d-%H_%M_%S")

Comment on lines +14 to 15
Copy link

Copilot AI Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new timestamp format omits the year, which may reduce uniqueness over different years if the output directory is reused. Consider including the year (e.g., "%Y%m%d-%H_%M_%S") to ensure folder names remain distinct.

Suggested change
return datetime.now().strftime("%m%d-%H_%M_%S")
return datetime.now().strftime("%Y%m%d-%H_%M_%S")

Copilot uses AI. Check for mistakes.
def __init__(
self, test_name: str, output_dir: str, unique_id: str | None = None, metadata: Optional[Dict[str, Any]] = None
Expand Down
Empty file removed tests/__init__.py
Empty file.
Empty file removed tests/cat_ai/__init__.py
Empty file.
2 changes: 1 addition & 1 deletion tests/cat_ai/test_reporter.py → tests/test_reporter.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from src.cat_ai.helpers.helpers import root_dir


def test_reporter_create_a_unique_folder_path() -> None:
def test_reporter_creates_a_unique_folder_path() -> None:
test_name = "unique_folder_path"
reporter1 = Reporter(test_name=test_name, output_dir=root_dir())
expected_dir_path = f"{root_dir()}/test_runs/{test_name}"
Expand Down
File renamed without changes.