Open
Conversation
app/models/user.rb
Outdated
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Member
|
Looks reasonable.... |
Contributor
|
Works for me |
There was a problem hiding this comment.
So I see employer_path in the other code, which will route correctly to this controller but then will crash because there's no show method in this controller. I see show and edit views for employers that can't be accessed because there are no show and edit methods.
I'd add show and edit methods here to prevent that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.