Conversation
nachojorge
force-pushed
the
remove-multipart-dependency
branch
4 times, most recently
from
0c20d6c to
a07101d
Compare
| @connection = PersistentHTTP.new( | ||
| :pool_size => 4, | ||
| :pool_timeout => 10, | ||
| :warn_timeout => 0.25, | ||
| :force_retry => false, | ||
| :url => url, | ||
|
|
||
| :read_timeout => timeout, | ||
| :open_timeout => timeout | ||
| pool_size: 4, | ||
| pool_timeout: 10, | ||
| warn_timeout: 0.25, | ||
| force_retry: false, | ||
| url: url, | ||
|
|
||
| read_timeout: timeout, | ||
| open_timeout: timeout |
There was a problem hiding this comment.
Why do we use these values for the proxy client?
Shouldn't we allow to customize this?
There was a problem hiding this comment.
Be patient Juancito 😂 The improvements in persistent connections are the next step.
| representation_object = representation_class.new(*fields.values, fields.transform_keys(&:to_s)) | ||
|
|
||
| fields = nil | ||
| representation_class = nil |
There was a problem hiding this comment.
Why did we remove this? Doesn't this keep retained memory?
There was a problem hiding this comment.
Nope, after some research, I realized we don't need to do this.
| RE_PATH_PARAM = /:\w+/ | ||
|
|
||
| SEVERE_STATUS_CODES = %w(500 501 503) | ||
| HTTP_METHODS_WITH_BODY = %w[post put].freeze |
There was a problem hiding this comment.
Also, why are we specifically freezing the strings if the magic comment does it for all strings in this file?
There was a problem hiding this comment.
The magic comment only freezes strings, and this is an array. The strings inside will be frozen, but not the array itself.
| when '.jpg' then 'image/jpeg' | ||
| when '.png' then 'image/png' | ||
| when '.gif' then 'image/gif' | ||
| else 'application/octet-stream' |
There was a problem hiding this comment.
What about pdfs or so, if we assign them as octet-streams we dont lose anything in the request?
There was a problem hiding this comment.
Nope, I tried it.
| module Angus | ||
| module Remote | ||
|
|
||
| VERSION = '0.0.16' |
There was a problem hiding this comment.
After the improvements in persistent connections, I can officially release version 1.0.0 😎
nachojorge
force-pushed
the
remove-multipart-dependency
branch
from
d833380 to
3145e82
Compare
nachojorge
force-pushed
the
remove-multipart-dependency
branch
from
3145e82 to
c2ddf7c
Compare
3 participants
No description provided.