Conversation
Add CameraType.FLAT_MAP, ICameraModeDelegate interface for plugin-provided camera modes, flat map pan/zoom state, and delegate lifecycle hooks.
Add renderCustomBackground, shouldSkipEarthDraw, shouldSkipSatelliteModels, and shouldSkipTransparentObjects events with methods-pattern support.
Allow plugins to override worldShift and skip default Earth, satellite model, and transparent object rendering via event bus methods.
…Toggle entry Add isLoginRequired flag to PluginDescriptor and set it on pro-gated plugins in the manifest. Wire login gate flag propagation in PluginManager. Add PoliticalMapToggle plugin manifest entry and config type.
…mode Replace [BASIC, ADVANCED, ALL] with [BASIC, ALL] across plugins since ADVANCED is no longer a distinct mode. Move filter-menu and orbit-guard to appropriate modes. Add screen-recorder to BASIC mode.
Add comprehensive tests for init-time disable, runtime disable/enable, interaction guards, and context menu visibility when planets are disabled.
…and guard icon state sync Remove duplicate selectSatData event handlers (already handled by base-plugin isRequireSatelliteSelected). Add isIconDisabled guard to prevent setting selected state on a disabled icon during updateLoop.
…r CSS tweaks Mark Collisions, LaunchCalendar, NextLaunches, and SatellitePhotos as requiresInternet. Add isIconDisabledOnLoad to ShortTermFences. Fix calculator checkbox line-height and remove unused border color. Move orbit-guard to ADVANCED mode. Localize watchlist-filter labels.
Hoist xlsx mock to module level with vi.mock for proper ESM interception. Add saveVariable mock to catalog-manager tests to avoid import side effects.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major CSS refactoring to reduce duplication, updates build configuration logic, and makes improvements to ESLint setup and VSCode settings. The most significant change is the extraction of common CSS code into a shared file, resulting in much smaller and more maintainable variant CSS files. Additionally, plugin management logic has been removed from the build process, and locale merging is now more robust. ESLint and VSCode settings have also been updated for improved development experience.
CSS Refactoring and Build System Improvements:
CSS Refactoring
style.css,style.celestrak.css, andstyle.embed.cssinto a newstyle.common.css, reducing each variant file to only its unique rules and organizing the common file into clear sections. Backups of original files are provided, and import statements are used for maintainability.Build System Changes
PluginManagerand related plugin configuration logic from the build process, simplifying build management and centralizing plugin handling elsewhere. (build/build-manager.tsandbuild/lib/plugin-manager.ts) [1] [2] [3] [4]pluginsanderrorMsgsare properly combined without overwriting keys. (build/lib/filesystem-manager.ts) [1] [2]Development Environment
jestplugin and environment, and added support forvitestglobals in the test config. This streamlines linting and aligns with the current test framework. (.eslintrc,.eslintrc.test.json) [1] [2] [3] [4] [5].vscode/settings.json)Miscellaneous
README.mdto reflect the new version after refactoring.webpack-manager.tsby importingresolvefrompathfor future use.