Open
Conversation
Collaborator
|
Great idea! :D Will have a look a bit later. |
remusao
reviewed
Sep 10, 2017
|
|
||
| 'use strict'; | ||
|
|
||
| var tldjs = require('..'); |
Collaborator
There was a problem hiding this comment.
Does it import index.js by default?
Owner
Author
There was a problem hiding this comment.
Yes it does import the index.js file of the parent path.
According to https://nodejs.org/api/modules.html#modules_folders_as_modules:
If there is no package.json file present in the directory, then Node.js will attempt to load an index.js or index.node file out of that directory.
Because there is a package.json file, if the main field would have declared a different filepath, the latter would have been loaded.
remusao
approved these changes
Jun 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to bind
tldjs.parse()to the first CLI argument/stdin: