Allow user to input moves using a pop up#205
Allow user to input moves using a pop up#205thomas-mauran merged 10 commits intothomas-mauran:mainfrom
Conversation
|
Hello @xiangsgao very nice job it seems to work fine.
- use another key than escape to open that popup, such as M (for move) for example which I think is not assigned yet
- In the popup above the esc to close and under the input we could have some examples like Nf3, e4, Qe2, exd5, or maybe a link to https://en.wikipedia.org/wiki/Algebraic_notation_(chess) directly to help user write the correct notation !
|
I see. This is a good suggestion. Done. A couple of things to mention: |
Works fine ! the popup is well placed no worries for the perfect fit, if you can just fix the linting issues so that the ci pass and I can merge that :) |
Sounds great. I just ran the formatter. All checks cleared. |
|
Perfect LGTM thank you @xiangsgao for your contribution ! |


Title
Allow the user to input moves using a pop-up
Description
Allow the user to input a new move using chess notation via a pop-up.
I have not done Rust programming for a long time, so do be critical and examine my changes thoroughly. Let me know if you would like to see any further changes.
Fixes #33
How Has This Been Tested?
Simply hit the escape key when it is your turn to see a pop-up in which you can then enter a chess notation for moves. I do not know how to play chess, so please help test a bit.
Checklist: