feat: allow lowercase san in the move popup#214
feat: allow lowercase san in the move popup#214thomas-mauran merged 17 commits intothomas-mauran:mainfrom
Conversation
|
Hello @xiangsgao great pr works well on my side, I tested multiple cases and don't see any issue. Thanks again for the fast patch ! |
Absolutely, this is a good idea. I don't know if SANs in the test are valid, but I can totally check that the helper function spits out a valid output. Actual validation of the SANs will be done later by the shakmaty::san::San crate. Updated. |
|
Works like a charm perfect thanks for your contribution and reactivity @xiangsgao ! |
Convert lower case letters into uppercase so they become valid sans
Description
If an user enters all lower case sans, this is sometimes invalid because lower case denotes pawn pieces only. I did not know that but yeah... this update should fix it.
Fixes # (213)
How Has This Been Tested?
Try entering all the possible SANs in lower case. Someone with more chess knowledge than me testing this would be helpful.
Checklist: