Skip to content

fix: return to ongoing games menu after resigning (issue #190)#223

Open
KapuuZapuu wants to merge 1 commit intothomas-mauran:mainfrom
KapuuZapuu:fix/issue-190
Open

fix: return to ongoing games menu after resigning (issue #190)#223
KapuuZapuu wants to merge 1 commit intothomas-mauran:mainfrom
KapuuZapuu:fix/issue-190

Conversation

@KapuuZapuu
Copy link

@KapuuZapuu KapuuZapuu commented Feb 16, 2026

Changed: [resign -> success -> lichess menu] TO [resign -> success -> ongoing games menu]

Description

Simple single line issue:

handler.rs (line 190):
Pages::Lichess | Pages::OngoingGames => {
CHANGED TO:
Pages::Lichess => {

Excluded the flow that caused success popups closed within the ongoing games menu to cause the user to get redirected back to the lichess menu. All success popups from that menu (ongoing games) will now make it so the user remains on that menu.

Fixes #190

How Has This Been Tested?

All other success popup windows return to their intended pages as normal. Neither traversed the code changed previously, so no alterations to their behavior was expected.

  • Successful lichess.org token input (from home page) -> lichess menu
  • Successful disconnect and token removal (from lichess menu) -> home page
  • Successful resignation from ongoing game (ongoing game menu) -> ongoing game menu

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@thomas-mauran
Copy link
Owner

Hello @KapuuZapuu thank you for your contribution, this seems to work, I think we are only missing a refetch of the ongoing games after resigning cause I still see the game we just resigned !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resigning a game sends us back to the Lichess menu

2 participants