fix: return to ongoing games menu after resigning (issue #190)#223
Open
KapuuZapuu wants to merge 1 commit intothomas-mauran:mainfrom
Open
fix: return to ongoing games menu after resigning (issue #190)#223KapuuZapuu wants to merge 1 commit intothomas-mauran:mainfrom
KapuuZapuu wants to merge 1 commit intothomas-mauran:mainfrom
Conversation
Owner
|
Hello @KapuuZapuu thank you for your contribution, this seems to work, I think we are only missing a refetch of the ongoing games after resigning cause I still see the game we just resigned ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed: [resign -> success -> lichess menu] TO [resign -> success -> ongoing games menu]
Description
Simple single line issue:
handler.rs (line 190):
Pages::Lichess | Pages::OngoingGames => {
CHANGED TO:
Pages::Lichess => {
Excluded the flow that caused success popups closed within the ongoing games menu to cause the user to get redirected back to the lichess menu. All success popups from that menu (ongoing games) will now make it so the user remains on that menu.
Fixes #190
How Has This Been Tested?
All other success popup windows return to their intended pages as normal. Neither traversed the code changed previously, so no alterations to their behavior was expected.
Checklist: