Skip to content

Fix for imperial pace when entering Running FTP #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danhjoo7 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix for imperial pace when entering Running FTP #1243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d09074
make fix for imperial units
danhjoo7 Dec 17, 2025
4dc0258
fix data type for method
danhjoo7 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .../app/athlete-settings/components/athlete-settings-form/athlete-settings-form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { SwimFtpHelperComponent } from "./swim-ftp-helper/swim-ftp-helper.compon
import { AthleteSettings } from "@elevate/shared/models/athlete/athlete-settings/athlete-settings.model";
import { MeasureSystem } from "@elevate/shared/enums/measure-system.enum";
import { Constant } from "@elevate/shared/constants/constant";
import { UserSettingsService } from "../../../shared/services/user-settings/user-settings.service";

@Component({
selector: "app-athlete-settings-form",
Expand Down Expand Up @@ -40,11 +41,19 @@ export class AthleteSettingsFormComponent implements OnInit {

public isSwimFtpCalculatorEnabled = false;

constructor(@Inject(MatSnackBar) private readonly snackBar: MatSnackBar) {}
public systemUnit: String;

constructor(
@Inject(MatSnackBar) private readonly snackBar: MatSnackBar,
@Inject(UserSettingsService) private readonly userSettingsService: UserSettingsService
) { }

public ngOnInit(): void {
this.markCurrentSettingsAsCompliant();
this.swimFtp100m = SwimFtpHelperComponent.convertSwimSpeedToPace(this.athleteSettingsModel.swimFtp);
this.userSettingsService.fetch().then(userSettings => {
this.systemUnit = userSettings.systemUnit;
});
}

public isPropertyCompliant(property: string, canBeNull?: boolean): boolean {
Expand Down Expand Up @@ -167,18 +176,17 @@ export class AthleteSettingsFormComponent implements OnInit {

public convertToPace(systemUnit: string): string {
let speedFactor: number;

if (systemUnit === MeasureSystem.METRIC) {
speedFactor = 1;
this.systemUnit === MeasureSystem.METRIC ? (speedFactor = 1) : (speedFactor = Constant.KM_TO_MILE_FACTOR);
} else if (systemUnit === MeasureSystem.IMPERIAL) {
speedFactor = Constant.KM_TO_MILE_FACTOR;
this.systemUnit === MeasureSystem.IMPERIAL ? (speedFactor = 1) : (speedFactor = 1 / Constant.KM_TO_MILE_FACTOR);
} else {
throw new Error("System unit unknown");
}

return _.isNumber(this.athleteSettingsModel.runningFtp) && this.athleteSettingsModel.runningFtp > 0
? this.secondsToHHMMSS(this.athleteSettingsModel.runningFtp / speedFactor) +
(systemUnit === MeasureSystem.METRIC ? "/km" : "/mi")
? this.secondsToHHMMSS(this.athleteSettingsModel.runningFtp * speedFactor) +
(systemUnit === MeasureSystem.METRIC ? "/km" : "/mi")
: null;
}

Expand Down