refactor(gossipsub): use dummy handler instead of calling `new_handle… #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r` (libp2p#3384)
The gossipsub tests are calling lifecycle functions of the
NetworkBehaviour
that aren't meant to be called outside ofSwarm
. This already surfaced as a problem in libp2p#3327 and it is coming up again in libp2p#3254 wherenew_handler
gets deprecated.Try to mitigate that by constructing a dummy handler instead. Functionally, there is no difference as in both cases, the given handler has never seen a connection.## Description
Notes
Links to any relevant issues
Open Questions
Change checklist