Skip to content

Conversation

thomaseizinger
Copy link
Owner

…r` (libp2p#3384)

The gossipsub tests are calling lifecycle functions of the NetworkBehaviour that aren't meant to be called outside of Swarm. This already surfaced as a problem in libp2p#3327 and it is coming up again in libp2p#3254 where new_handler gets deprecated.

Try to mitigate that by constructing a dummy handler instead. Functionally, there is no difference as in both cases, the given handler has never seen a connection.## Description

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant