Feature: Support modify channels with native encoding#39
Open
zeehio wants to merge 17 commits intothomasp85:mainfrom
Open
Feature: Support modify channels with native encoding#39zeehio wants to merge 17 commits intothomasp85:mainfrom
zeehio wants to merge 17 commits intothomasp85:mainfrom
Conversation
zeehio
force-pushed
the
feat-change-channel-native
branch
from
a2cfd4d to
b6418df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created on top of #38, this pull request provides
set_channel(),add_to_channel(),multiply_channel(),raise_channel(), andcap_channel()versions (suffixed with_native) that operate on native encoding colours (those from nativeRaster objects).As the other pull requests this is based on, this is part of tidyverse/ggplot2#4989, which aims to improve the performance of ggplot when rasterizing a large matrix.
My plan when this gets merged is to propose enhancements in the scales package that leverage these patches and that can be used by ggplot2 to perform better.
I don't have further patches planned for farver.