feature: copy as "SVG Markup" syntax (embeddable in HTML)#63
Open
grimen wants to merge 1 commit intothomaspark:gh-pagesfrom
Open
feature: copy as "SVG Markup" syntax (embeddable in HTML)#63grimen wants to merge 1 commit intothomaspark:gh-pagesfrom
grimen wants to merge 1 commit intothomaspark:gh-pagesfrom
Conversation
Quickly queried and transpiled from embedded *.svg fonts. A generic approach that works with any icon fonts without extra work. Additional requirement: Adds `library` to each icon instance, makes sense for other reasons too.
Contributor
Author
|
fixes #49 |
Contributor
Author
|
Status on this? |
Owner
|
Tested it out and it's working good overall. With the conflicts cleaned up: https://github.com/thomaspark/glyphsearch/tree/grimen-feature-copy-svg-markup However, there is an issue with Material Design Icons. In the SVG file MaterialIcons-Regular.svg, each glyph actually has its unicode attribute filled with the glyph-name. Once this is corrected in their library, this should be good to go.
|
Contributor
Author
|
OK, should be a minor fix but will see when I got time too look at it because deadlines and summertimes. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quickly queried and transpiled from embedded *.svg fonts. A generic
approach that works with any icon fonts without extra work. Additional
requirement: Adds
libraryto each icon instance, makes sense forother reasons too.