-
-
Notifications
You must be signed in to change notification settings - Fork 173
feat: add support for all retrievers in cli #4025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add support for all retrievers in cli #4025
Conversation
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
Signed-off-by: deamondev <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4025 +/- ##
==========================================
+ Coverage 83.92% 84.04% +0.11%
==========================================
Files 137 137
Lines 6813 6968 +155
==========================================
+ Hits 5718 5856 +138
- Misses 884 897 +13
- Partials 211 215 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
I added new flags related to other kind of retrievers. Based on them the new retriever is being spawned (but see #4024).
There is also new
--check-mode
flag which when present would only dump the configuration of retriever being used to performevaluate
call. It also served me while testing some multi-flags (like http's--header
) because there is some kind of parsing logic atevaluate_cmd
layer.The
redis
retriever is not supported because of #4023. We may of course hack it and provide empty output when-kind=redis
but I think the refactor ofRetrieverConf
struct would benefit more.Closes issue(s)
Resolve #3876
Checklist
README.md
and/website/docs
)