chore(wasm): Build for wasm-unknown instead of gojs#4366
chore(wasm): Build for wasm-unknown instead of gojs#4366andreaTP wants to merge 1 commit intothomaspoignant:mainfrom
wasm-unknown instead of gojs#4366Conversation
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
| } | ||
|
|
||
|
|
||
| // alloc/free implementation for wasm-unknown target from: |
There was a problem hiding this comment.
When not targeting wasm-wasi or gojs tinygo doesn't exports those functions.
Here we are exporting stable identifiers to be used on any target.
There was a problem hiding this comment.
oh I didn't know about that, thanks for the addition.
I will test the full pipeline locally with your 2 PRs tonight or tomorrow.
There was a problem hiding this comment.
Let me know how it goes and we continue from there 👍
wasm-unknown instead of gojswasm-unknown instead of gojs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4366 +/- ##
==========================================
- Coverage 85.06% 84.98% -0.09%
==========================================
Files 142 143 +1
Lines 5893 5939 +46
==========================================
+ Hits 5013 5047 +34
- Misses 662 674 +12
Partials 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wasm-unknown instead of gojswasm-unknown instead of gojs
|
@andreaTP I've done some tests and I end up with errors like |
|
@thomaspoignant which version of Java are you using? I suggest you try with Java21+ as a first iteration. Also we might need to increase the default memory limits: Instance.builder().withMemoryLimits(new MemoryLimits(10))"should" make the trick, if you have a reproducer I can take a look :-) |



Description
This changes the build to wasm to be targeting wasm-unknown the most "platform agnostic" compilation target.
I attempted to quickly test the result in
open-feature/java-sdk-contribbut one test seems to be looping, I haven't narrowed down the root cause yet.Closes issue(s)
Resolve #
Checklist
README.mdand/website/docs)