Skip to content

Conversation

@TimothyMakkison
Copy link
Contributor

Skip List creation if TestClassType is null.

  • Would be a good candidate for ValueListBuilder if this is a hot path

@thomhurst
Copy link
Owner

APPROVE - Clean performance optimization. Avoids List allocation when TestClassType is null and removes redundant .OfType conversions. Both AotTestDataCollector and ReflectionTestDataCollector updated identically (dual-mode Rule #1). Reduces allocations in test discovery hot path (Rule #4 Performance First). No critical issues found.

@thomhurst thomhurst merged commit bc9fb9a into thomhurst:main Jan 7, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants