-
-
Notifications
You must be signed in to change notification settings - Fork 108
perf: skip List creation in GetDynamicTestAttributes
#4195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallstop
reviewed
Dec 30, 2025
60debb0 to
e8ce7a5
Compare
Owner
|
APPROVE - Clean performance optimization. Avoids List allocation when TestClassType is null and removes redundant .OfType conversions. Both AotTestDataCollector and ReflectionTestDataCollector updated identically (dual-mode Rule #1). Reduces allocations in test discovery hot path (Rule #4 Performance First). No critical issues found. |
This was referenced Jan 7, 2026
This was referenced Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
Listcreation ifTestClassTypeisnull.ValueListBuilderif this is a hot path