chore(pages): replace JamesIves/github-pages-deploy-action with actions/deploy-pages#153
Open
chuanye-gao wants to merge 1 commit intothomvaill:developfrom
Open
chore(pages): replace JamesIves/github-pages-deploy-action with actions/deploy-pages#153chuanye-gao wants to merge 1 commit intothomvaill:developfrom
chuanye-gao wants to merge 1 commit intothomvaill:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
What does this PR do?
This PR replaces the third-party
JamesIves/github-pages-deploy-actionwith the official GitHub Pagesdeployment workflow based on:
actions/upload-pages-artifactactions/deploy-pagesThe demo ADR site is still generated using
log4brains build, which aggregatesall ADR sources declared in
.log4brains.ymlinto a single static site.Why this change?
GitHub now recommends deploying Pages sites via Actions artifacts instead of
pushing generated files to a dedicated branch.
Migrating to the official Pages Actions:
Implementation details
log4brains build.log4brains/out) as a Pages artifactactions/deploy-pages.log4brains.yml) or generation logic change.Notes on migration
This PR does not remove or modify the existing
gh-pagesbranch deployment.After merging, the Pages source can be switched to “GitHub Actions” in the
repository settings.