This repository was archived by the owner on Feb 14, 2019. It is now read-only.
Open
Conversation
Author
|
I'm not sure why that test fails and I think that is not caused by my changes because I ran the tests on master branch on my environment and the same result. |
Owner
|
Unfortunately there are some flaky tests. Running the build again made it pass. I left a couple of comments on: e6c65d2 Thank you Marius |
thorin
force-pushed
the
master
branch
12 times, most recently
from
3edb2cb to
d7d7b52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements issue #158 and allows to sync with ldap three user attributes (Department, Job Title and Phone number) from Redmine People plugin.
@thorin, before I add tests, please tell me what do you think about this PR.
The change from test/functional/ldap_settings_controller_test.rb is for compatibility with MT6 (where assert_equal nil will fail).