Skip to content

Update .htaccess rewrite and error handling logic #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thorsten merged 2 commits into from
Dec 11, 2025
Merged

Update .htaccess rewrite and error handling logic #3803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9d3b9
Update .htaccess rewrite and error handling logic
d0ubIeU Dec 11, 2025
21c8ae5
fix
d0ubIeU Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions phpmyfaq/src/phpMyFAQ/Setup/EnvironmentConfigurator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,15 @@ public function getRewriteBase(): string
}

/**
* Adjusts the RewriteBase in the .htaccess file for the user's environment to avoid errors with controllers.
* Returns true, if the file was successfully changed.
* Adjusts the RewriteBase and ErrorDocument 404 in the .htaccess file for the user's environment.
*
* @throws Exception
* This method ensures that URL routing works correctly and 404 errors are properly handled.
*
* - RewriteBase is set to the application's installation path (e.g., /faq/)
* - ErrorDocument 404 is configured to route errors to the application's error handler (e.g., /faq/index.php?action=404)
*
* @return bool Returns true if the .htaccess file was successfully modified, false otherwise.
* @throws Exception If the .htaccess file does not exist or contains syntax errors during parsing.
*/
public function adjustRewriteBaseHtaccess(): bool
{
Expand All @@ -89,10 +94,19 @@ public function adjustRewriteBaseHtaccess(): bool
throw new Exception('Error parsing .htaccess file: ' . $e->getMessage());
}

// Adjust RewriteBase
$rewriteBase = $htaccess->search('RewriteBase', TOKEN_DIRECTIVE);
if ($rewriteBase) {
$rewriteBase->removeArgument($this->getRewriteBase());
$rewriteBase->setArguments((array) $this->getServerPath());
}

$rewriteBase->removeArgument($this->getRewriteBase());
$rewriteBase->setArguments((array) $this->getServerPath());
// Adjust ErrorDocument 404
$errorDocument404 = $htaccess->search('ErrorDocument 404', TOKEN_DIRECTIVE);
if ($errorDocument404) {
$new404Path = rtrim($this->getServerPath(), '/') . '/index.php?action=404';
$errorDocument404->setArguments([(string) $new404Path]);
}

$output = (string) $htaccess;
return (bool) file_put_contents($this->htaccessPath, $output);
Expand Down