Skip to content

Fix encoding of generic type when boxing #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bruno-cadorette wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix encoding of generic type when boxing #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Encode.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,10 +412,10 @@ module Encode =
FSharpType.GetRecordFields(t, allowAccessToPrivateRepresentation=true)
|> Array.map (fun fi ->
let targetKey = Util.Casing.convert caseStrategy fi.Name
let encoder = autoEncoder extra caseStrategy skipNullField fi.PropertyType
fun (source: obj) (target: JObject) ->
let value = FSharpValue.GetRecordField(source, fi)
if not skipNullField || (skipNullField && not (isNull value)) then // Discard null fields
let encoder = autoEncoder extra caseStrategy skipNullField (value.GetType())
target.[targetKey] <- encoder.Encode value
target)
boxEncoder(fun (source: obj) ->
Expand Down