Skip to content

🐛 Fix podcasts appearing in the "Writing" list #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
purinkle merged 1 commit into from
May 30, 2025
Merged

🐛 Fix podcasts appearing in the "Writing" list #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/combined_rss_feed.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
require "rss_feed"

class Feedjira::Parser::ITunesRSSItem
element "thoughtbot:auto_social_share", as: :auto_social_share
end

class CombinedRssFeed
include Enumerable

Expand Down
6 changes: 5 additions & 1 deletion lib/rss_feed.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

require "feed_item"

class Feedjira::Parser::AtomEntry
element "thoughtbot:auto_social_share", as: :auto_social_share
end

class RssFeed
include Enumerable

Expand All @@ -12,7 +16,7 @@ def initialize(url:)
end

def each
feed.entries.each do |entry|
feed.entries.reject { it.auto_social_share == "false" }.each do |entry|
yield FeedItem.new(
id: entry.id,
title: entry.title,
Expand Down
52 changes: 52 additions & 0 deletions spec/rss_feed_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,58 @@
)
end

it "ignores entries we don't automatically share to social media" do
Excon.stub({}, {status: 200, body: <<~XML.chomp})
<?xml version="1.0" encoding="UTF-8"?>
<feed xmlns="http://www.w3.org/2005/Atom">
<title>TEST_FEED_TITLE</title>
<subtitle>TEST_SUBTITLE</subtitle>
<id>https://example.com/</id>
<link href="https://example.com/blog"/>
<link href="https://example.com/blog/feed.xml" rel="self"/>
<updated>2024-12-20T00:00:00+00:00</updated>
<author>
<name>TEST_NAME</name>
</author>
<entry>
<title>TEST_ENTRY_1</title>
<link rel="alternate" href="https://example.com/test-entry-1"/>
<author>
<name>TEST_AUTHOR</name>
</author>
<id>https://example.com/test-entry-1</id>
<published>2025-05-22T00:00:00+00:00</published>
<updated>2025-05-22T12:40:11Z</updated>
<content type="html">
<![CDATA[TEST_CONTENT]]>
</content>
<summary>TEST_SUMMARY</summary>
<thoughtbot:auto_social_share>false</thoughtbot:auto_social_share>
</entry>
<entry>
<title>TEST_ENTRY_2</title>
<link rel="alternate" href="https://example.com/test-entry-2"/>
<author>
<name>TEST_AUTHOR</name>
</author>
<id>https://example.com/test-entry-2</id>
<published>2025-05-29T00:00:00+00:00</published>
<updated>2025-05-29T12:40:11Z</updated>
<content type="html">
<![CDATA[TEST_CONTENT]]>
</content>
<summary>TEST_SUMMARY</summary>
<thoughtbot:auto_social_share>true</thoughtbot:auto_social_share>
</entry>
</feed>
XML
rss_feed = RssFeed.new url: "https://example.com/blog/feed.xml"

entries_titles = rss_feed.map(&:title)

expect(entries_titles).to contain_exactly "TEST_ENTRY_2"
end

def atom_feed
File.read("spec/fixtures/rss_feed.xml")
end
Expand Down