Add requireness to HasOne form#2812
Conversation
|
Can you think of a reasonable way to test this, so we don't break it in future? |
|
I will think of a reasonable way to test this and add it! |
|
I've added tests. By the way, Would you consider adding more columns? |
|
Regarding this method name, is "requireness" correct? Should it be "requiredness" instead? |
We should add more if it's needed for testing. The demo app has grown organically and is neither consistent nor coherent in how it works. I've long wanted to switch the demo app to follow a particular pattern. Maybe a shop or something.
I think "requiredness" is likely more correct, according to the OED it is a word, although not a common one. |
db181cc to
0d833b1
Compare
|
Rebased! |
0d833b1 to
e50a6e4
Compare
|
Rebased. |
For a while now I've been thinking that ideally we should have several example apps, or one with several admin interfaces handling unrelated models (or perhaps related). I feel that trying to get every single use case with a single app gets out of hand pretty quickly. |
|
I think this is good |
|
What do you think about moving this into a separate dedicated repository? Something like For example, we could provide multiple implementations for I think this would help users get a better sense of how things can be used in practice, and also serve as a reference for implementation. In an ideal world, it could become a place where we can easily try out Fields built on top of minor gems just to see how they feel. Just a thought. |
The nested form for HasOne didn't have the requiredness mark, so I added it.
Before:
After: