Extend tiebreaking to all association orderings#3006
Open
goosys wants to merge 1 commit intothoughtbot:mainfrom
Open
Extend tiebreaking to all association orderings#3006goosys wants to merge 1 commit intothoughtbot:mainfrom
goosys wants to merge 1 commit intothoughtbot:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, tiebreaking by primary key was introduced for direct column ordering.
However, association-based orderings (
has_many,belongs_to,has_one) did not benefit from the same behavior.This PR extends tiebreaking to all association orderings by extracting the logic into a shared
with_tiebreakhelper. Each association ordering method now passes its result throughwith_tiebreak, which appends anORDER BY primary_keyclause when applicable.No tiebreak is added when the parent relation has no primary key.