Support executing with :cuprite and :playwright drivers
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
axe-core-js
branch
3 times, most recently
from
86d50ed to
a3c90b4
Compare
seanpdoyle
changed the title
:cuprite and :playwrigt drivers:cuprite and :playwright drivers
seanpdoyle
force-pushed
the
axe-core-js
branch
17 times, most recently
from
d5b6dd9 to
5e22602
Compare
In an effort to support more than Selenium-based drivers, this change modifies the underlying `axe.js` integration. Prior to this change, this gem relied entirely on the [axe-core-api][] dependency to execute the audit, collect the results, and raise any violations as testing exceptions. Unfortunately, that gem does not provide official support for drivers other than Selenium ([axe-core-gems#243][]). To account for that shortcoming, this commit changes the gem to integrate with the `axe.js` JavaScript code more directly, including changes that invoke the interface directly through a combination of Capybara's [execute_script][], [evaluate_script][], and [evaluate_async_script][]. In support of that integration, this commit also extracts the `AxeAuditor` and `RaiseReporter` classes for the sake of abstracting the auditing and reporting steps (and for future integrations with other styles of audit reporting). [axe-core-api]: https://github.com/dequelabs/axe-core-gems/tree/develop/packages/axe-core-api [axe-core-gems#243]: dequelabs/axe-core-gems#243 [execute_script]: https://rubydoc.info/github/teamcapybara/capybara/master/Capybara/Session:execute_script [evaluate_script]: https://rubydoc.info/github/teamcapybara/capybara/master/Capybara/Session:evaluate_script [evaluate_async_script]: https://rubydoc.info/github/teamcapybara/capybara/master/Capybara/Session:evaluate_async_script
seanpdoyle
force-pushed
the
axe-core-js
branch
from
5e22602 to
3945ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to support more than Selenium-based drivers, this change modifies the underlying
axe.jsintegration.Prior to this change, this gem relied entirely on the axe-core-api dependency to execute the audit, collect the results, and raise any violations as testing exceptions.
Unfortunately, that gem does not provide official support for drivers other than Selenium (axe-core-gems#243).
To account for that shortcoming, this commit changes the gem to integrate with the
axe.jsJavaScript code more directly, including changes that invoke the interface directly through a combination of Capybara's execute_script, evaluate_script, and evaluate_async_script.In support of that integration, this commit also extracts the
AxeAuditorandRaiseReporterclasses for the sake of abstracting the auditing and reporting steps (and for future integrations with other styles of audit reporting).