Support :traits option on implicit association#1552
Open
r7kamura wants to merge 1 commit intothoughtbot:mainfrom
Open
Support :traits option on implicit association#1552r7kamura wants to merge 1 commit intothoughtbot:mainfrom
:traits option on implicit association#1552r7kamura wants to merge 1 commit intothoughtbot:mainfrom
Conversation
13 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we want to specify traits in implicit associations, we have to use
:factoryoption. This is not only a naming problem, but also redundant in implicit style, because when using:factoryoption, the main factory name must always be specified, so the same name must be written twice.To resolve this problem, I propose to allow
:traitsoption on implicit associations in this Pull Request.