BugFix: standardise parity on :increment_sequence#1756
Merged
neilvcarvalho merged 1 commit intothoughtbot:mainfrom Jul 18, 2025
Merged
BugFix: standardise parity on :increment_sequence#1756neilvcarvalho merged 1 commit intothoughtbot:mainfrom
neilvcarvalho merged 1 commit intothoughtbot:mainfrom
Conversation
- Refactored :increment_sequence to remove the URI requirement. - Updated sequence specs for both direct and implicit strategy use. - FactoryBot.build(:user) - build(:user)
CodeMeister
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1754
The issue was
.increment_sequencewithinFactoryBot::Evaluatorwas un-defining, then replacing, the.increment_sequencemethod included fromFactoryBot::Syntax::Methods, but there was a parity miss-match.No change to the user API.