Add AuthenticationGenerator for users factory creation #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses an issue where running the `factory_bot` generator could result in a `factory_bot [not found]` error. The problem occurred due to missing generator definitions and template files. With this update, the authentication generator is properly defined and includes the necessary templates, ensuring that the `users.rb` factory file is generated regardless of whether the project is using RSpec (`spec/factories`) or Minitest (`test/factories`). This guarantees consistent behavior and avoids generator errors in environments without a `spec` directory. Previously, projects without a `spec` directory or with incomplete generator/template setup would fail when invoking `factory_bot` generators, making it impossible to scaffold the necessary factory files automatically. - Added the missing `factory_bot:authentication` generator definition. - Included `users.rb` template under `templates` directory. - Implemented logic to detect the test framework and place the generated factory file in the correct directory (`spec/factories` or `test/factories`). - Ensured generator runs successfully regardless of the presence of a `spec` directory.
rodrigotoledo
requested review from
DoodlingDev,
neilvcarvalho and
vburzynski
as code owners
|
Closing in favor of #542 - but I'll give you credits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses an issue where running the
factory_botgenerator could result in afactory_bot [not found]error. The problem occurred due to missing generator definitions and template files.With this update, the authentication generator is properly defined and includes the necessary templates, ensuring that the
users.rbfactory file is generated regardless of whether the project is using RSpec (spec/factories) or Minitest (test/factories). This guarantees consistent behavior and avoids generator errors in environments without aspecdirectory.Previously, projects without a
specdirectory or with incomplete generator/template setup would fail when invokingfactory_botgenerators, making it impossible to scaffold the necessary factory files automatically.factory_bot:authenticationgenerator definition.users.rbtemplate undertemplatesdirectory.spec/factoriesortest/factories).specdirectory.