Feature: rendering optional attributes#31
Open
kortirso wants to merge 1 commit intothoughtbot:mainfrom
Open
Conversation
Open
Contributor
|
Thanks for this PR! Out of the 3 PRs, i think this is one that i'm not fully ready for. Even if its manual, I do prefer the explicitness of if object.value
json.properties do
json.value object.value
end
endOther thoughts I have are.
I think i'll leave this PR open for a bit to see if there are other commenters, but I think your approach in the meantime is a good path, extend props_template. I also wonder if we can modify the syntax somehow using the block extension manager: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jho406 in continue #30
json.optional!- defines attribute or structure and marks it as optional, during serialization this method checks condition and renders or does not render such attributeexample of usage
Works with partials, I just think how optionals can be used in simple template