Conversation
This commit was missing from the 2.0 release and includes several related improvements: 1. Adds fragmentContext to allow digging using props_at to find a node, then considering what fragment it was found in, returns a `found_path` that can be used in a graft response's `path`. We'll need to replace the generated files in superglue_rails 2. Modifies `fragments!` to return paths that are relative to the data being presented. So instead of `data.a.deep.path.in.page` it returns. `data.a.deep.path.in.response` with the latter being much shorter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit was missing from the 2.0 release and includes several related improvements:
Adds fragmentContext to allow digging using props_at to find a node, then considering what fragment it was found in, returns a
found_paththat can be used in a graft response'spath. We'll need to replace the generated files in superglue_railsModifies
fragments!to return paths that are relative to the data being presented. So instead ofdata.a.deep.path.in.pageit returns.data.a.deep.path.in.responsewith the latter being much shorter.