fix: Prevent ActiveRecord constant leak in uniqueness matcher#1694
Merged
matsales28 merged 1 commit intomainfrom Feb 1, 2026
Merged
fix: Prevent ActiveRecord constant leak in uniqueness matcher#1694matsales28 merged 1 commit intomainfrom
matsales28 merged 1 commit intomainfrom
Conversation
matsales28
force-pushed
the
matheussales/1663-fix-active-record-constant-leak
branch
from
8a46d57 to
26f67cb
Compare
When using the validate_uniqueness_of matcher, test model classes were being added to ActiveRecord::Base.descendants and not being removed after the matcher ran. This could lead to unexpected behavior in tests that rely on the list of ActiveRecord descendants. Closes #1663
matsales28
force-pushed
the
matheussales/1663-fix-active-record-constant-leak
branch
from
26f67cb to
0c25055
Compare
matsales28
deleted the
matheussales/1663-fix-active-record-constant-leak
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the validate_uniqueness_of matcher, test model classes were being added to ActiveRecord::Base.descendants and not being removed after the matcher ran. This could lead to unexpected behavior in tests that rely on the list of ActiveRecord descendants.
Closes #1663