Fix accidental frozen obj #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `useSetFragment`, the obj returned was frozen. This cause a javascript invariant violation which breaks the proxy leading to this error discovered on #173 ``` Uncaught TypeError: 'get' on proxy: property 'toggleForm' is a read-only and non-configurable data property on the proxy target but the proxy did not return its actual value (expected '#<Object>' but got '#<Object>') at Item (ItemsList.jsx:11:5) at Object.react_stack_bottom_frame (react-dom-client.development.js:23863:20) ... etc .. ``` The fix is to use a local instance of Immer and setting the auto freeze to false.
jho406
force-pushed
the
fix-use-set-fragment-proxy
branch
from
f3ad2b1 to
c5a0230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
useSetFragment, the obj returned was frozen. This cause a javascript invariant violation which breaks the proxy leading to this error discovered on#173
The fix is to use a local instance of Immer and setting the auto freeze to false.