Open
Conversation
0x-r4bbit
reviewed
Nov 6, 2017
| 2. Import `ContactsListComponent` in `src/app/app.module.ts` and add it to the module's `declarations`. | ||
| 2. Create `src/app/app.routes.ts`, import the `ContactsListComponent` and export an array with routes (e.g. `export const APP_ROUTES = [...]`), holding one route pointing to `ContactsListComponent`. | ||
| 3. In `app.module.ts` import `RouterModule` from `@angular/router` and `APP_ROUTES` from `./app/app.routes` | ||
| 3. In `app.module.ts` import `RouterModule` from `@angular/router` and `APP_ROUTES` from `./app.routes` |
Member
There was a problem hiding this comment.
If we really want to do that then it should be ./src/app/app.routes . The ./app/ indicates that we're putting this file in there. ./app.routes tells me it's the root of the projects (so next to src) which would be wrong..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.