feat: alphabetically order blips#330
Conversation
|
@marisahoenig @devansh-sharma-tw - any feedback re: this PR? |
|
Hey @setchy — from what I've seen, the blips are already numbered alphabetically. Can you confirm if this is still needed? |
Hi @marisahoenig - you are correct, it does order alphabetically, however, it isn't case-insensitive, unlike that of thoughtworks.com/radar based on side-by-side comparisons. The key change in this PR is converting the blip name to lowercase during the ordering process |
|
@will-amaral - appreciate your thoughts on this PR |
|
@yashanandan - great to see this repo releasing again. I'd be happy to help refresh my open PRs if you had the time to review them 🙏 |
There was a problem hiding this comment.
Pull request overview
Adds deterministic, case-insensitive alphabetical ordering for blips (by name) when building the radar graph so that blips appear consistently ordered within their quadrant/ring groupings.
Changes:
- Import
lodash/orderByand introduce asortBlipsAlphabeticallyhelper. - Sort
blipsinplotRadarGraphprior to adding them to quadrants/rings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Sort blips by quadrant, ring, and name | ||
| blips = sortBlipsAlphabetically(blips) | ||
|
|
||
| blips.forEach((blip) => { | ||
| blip.ring = featureToggles.normalizeRingNameHoldToCaution ? normalizeRingNameHoldToCaution(blip.ring) : blip.ring |
Case-insensitive ordering of blips by name within their quadrant and ring