-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix: Enhance autocomplete search for special characters (accents) #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bob10042
wants to merge
1
commit into
thoughtworks:master
Choose a base branch
from
bob10042:fix/issue-356-special-characters
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| const { normalizeText } = require('../../src/util/textNormalizer') | ||
|
|
||
| describe('autoComplete', () => { | ||
| describe('normalizeText', () => { | ||
| it('should convert text to lowercase', () => { | ||
| expect(normalizeText('HELLO WORLD')).toBe('hello world') | ||
| expect(normalizeText('Test Case')).toBe('test case') | ||
| }) | ||
|
|
||
| it('should remove Portuguese accents', () => { | ||
| expect(normalizeText('Autorização')).toBe('autorizacao') | ||
| expect(normalizeText('Experiência')).toBe('experiencia') | ||
| expect(normalizeText('ação')).toBe('acao') | ||
| expect(normalizeText('coração')).toBe('coracao') | ||
| }) | ||
|
|
||
| it('should remove Spanish accents', () => { | ||
| expect(normalizeText('señor')).toBe('senor') | ||
| expect(normalizeText('niño')).toBe('nino') | ||
| expect(normalizeText('mañana')).toBe('manana') | ||
| }) | ||
|
|
||
| it('should remove French accents', () => { | ||
| expect(normalizeText('café')).toBe('cafe') | ||
| expect(normalizeText('résumé')).toBe('resume') | ||
| expect(normalizeText('naïve')).toBe('naive') | ||
| expect(normalizeText('façade')).toBe('facade') | ||
| }) | ||
|
|
||
| it('should remove German umlauts', () => { | ||
| expect(normalizeText('über')).toBe('uber') | ||
| expect(normalizeText('Mädchen')).toBe('madchen') | ||
| expect(normalizeText('schön')).toBe('schon') | ||
| }) | ||
|
|
||
| it('should handle mixed accented and non-accented text', () => { | ||
| expect(normalizeText('Continuous Delivery práticas')).toBe('continuous delivery praticas') | ||
| expect(normalizeText('Test Automation técnicas')).toBe('test automation tecnicas') | ||
| }) | ||
|
|
||
| it('should preserve text without accents', () => { | ||
| expect(normalizeText('hello world')).toBe('hello world') | ||
| expect(normalizeText('Kubernetes')).toBe('kubernetes') | ||
| expect(normalizeText('React.js')).toBe('react.js') | ||
| }) | ||
|
|
||
| it('should handle empty string', () => { | ||
| expect(normalizeText('')).toBe('') | ||
| }) | ||
|
|
||
| it('should handle numbers and special characters', () => { | ||
| expect(normalizeText('Test123!')).toBe('test123!') | ||
| expect(normalizeText('hello@world.com')).toBe('hello@world.com') | ||
| }) | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /** | ||
| * Normalize text by removing diacritical marks for accent-insensitive search | ||
| * This allows searching for "Autorizacao" to match "Autorização" (Portuguese) | ||
| * or "Experiencia" to match "Experiência" | ||
| * | ||
| * @param {string} text - The text to normalize | ||
| * @returns {string} - Lowercase text with diacritical marks removed | ||
| */ | ||
| const normalizeText = (text) => { | ||
| return text | ||
| .toLowerCase() | ||
| .normalize('NFD') | ||
| .replace(/[\u0300-\u036f]/g, '') | ||
| } | ||
|
|
||
| module.exports = { normalizeText } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This spec file is named
autoComplete-spec.jsand the top-leveldescribeis'autoComplete', but the tests only exercisenormalizeTextfromtextNormalizer.js. Other util specs (for examplespec/util/urlUtils-spec.js:1-6andspec/util/inputSanitizer-spec.js:1-4) follow a convention where the spec file name and top-leveldescribematch the module under test. To keep tests discoverable and aligned with that convention, consider renaming this spec to something liketextNormalizer-spec.jsand updating the top-leveldescribeto'textNormalizer'(or similar).